Jelmer Vernooij has voted tweak.
Status is now: Conditionally approved
Comment:
I'm not a big fan of names+dates in comments, since attribution can 
always be retrieved using annotate. Instead, I think the contents of 
that comment would be more appropriate as commit message.

Also, the if statement seems pointless since you're opening files and 
directories in the same way now.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C4883BE2D.5090504%40xs4all.nl%3E

-- 
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.canonical.com/mailman/listinfo/bzr-gtk

Reply via email to