Am Dienstag, den 22.07.2008, 21:53 +0200 schrieb Jasper Groenewegen: > I moved the if statement below the try-do_push() block. Maybe test for > revs > 0 before setting the push location? I think setting the push location is a good idea as long as pushing to it works. Pushing zero revisions is a success imho, since it is very well possible you'll want to push to that branch in the future to make it up to date. Your current fix is fine imo since it will not save in the obvious error situations (typo in the URL for example).
Cheers, Jelmer > Jelmer Vernooij wrote: > > On Tue, Jul 22, 2008 at 11:40:30AM +0200, Jasper Groenewegen wrote: > >> Remove question to set default pushlocation when None set yet. Users > >> would expect this to be set anyway. > > It would be nice to only set this if the push was successful, but I'm > > also happy to see that happen in a future patch. > > > > bb:approve > > > > Cheers, > > > > Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED] -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
