Hi Dennis, Am Samstag, den 02.08.2008, 18:10 -0600 schrieb millerdl: > A prior patch from Kevin Light under bug 244308 fixes the case of Olive > crashing > if the current working directory is on a mapped drive. A more recent bug > 250804 > also identifies the problem exists for removable drives (e.g. USB sticks) > as > well. The attached patch (against trunk) corrects that problem. > > I'm brand new with Bazaar so I don't know if it would cause other problems, > but > it seems that all drives that can be reached should be included. In that > case, > the check could be changed to accept any drive that returns a code greater > than > 1 (return code 0 is win32file.DRIVE_UNKNOWN and 1 is > win32file.DRIVE_NO_ROOT_DIR, the latter being what is returned when the drive > doesn't exist). Yeah, that makes sense. For the upcoming release, I'd rather stay on the safe side and just use your patch rather than change the code to only exclude nonexistent drives.
The patch looks ok to me, so I'll give my +1 for including it. Once one of the other developers does that as well, it'll be merged into trunk (and included in 0.95, which will hopefully be released in a couple of days). bb:approve The status of your patch can be followed at http://bundlebuggy.aaronbentley.com/project/bzr-gtk/request/% 3C4894F764.1020204%40telusplanet.net%3E Cheers, Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED]
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
