On Thu, 2008-10-23 at 10:28 +0200, Vincent Ladeuil wrote: > Subject pretty much says it all. > > As mentioned in the bug comment, this has some drawbacks because > the base class defines the semantic of 'ctrl-W' and 'ctrl-Q' a > bit aggressively. > > The actual definition is fine when there is only one window > opened by a given command but here the gstatus window can spawn > one or several diff windows and closing one shouldn't bring the > other down. > > Arguably closing the status window itself may close all children > windows though. > > Since changing that behavior will be invasive regarding other > commands, I didn't try to implement it to fix that bug, but that > something that we may want to consider. > > Concretely, instead of calling destroy() on ctrl-W we should call > close() which itself can call destroy(). And we shouldn't call > main_quit() if parent is None but instead leave that to the upper > level to handle (which knows if children windows has been opened > and can decide whether it's appropriate to quit or not). bb:approve
Cheers, Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED]
signature.asc
Description: This is a digitally signed message part
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
