On Wed, Jul 23, 2014 at 06:02:33PM +0200, Jakub Hrozek wrote: > On Tue, Jul 01, 2014 at 09:47:43AM +0100, David Drysdale wrote: > > On Tue, Jul 1, 2014 at 9:36 AM, Jakub Hrozek <jhro...@redhat.com> wrote: > > > > > On Mon, Jun 09, 2014 at 10:22:23AM +0100, David Drysdale wrote: > > > > Hi folks, > > > > > > > > A GitHub commenter [1] says that my recent change to ahost.c has > > > > problems compiling on Windows + C89 platforms. I've attached a > > > > putative patch below, but I don't have access to the relevant platform > > > > to check it -- can anyone confirm the problem & solution? > > > > > > > > Thanks, > > > > David > > > > > > > > [1] > > > https://github.com/bagder/c-ares/commit/ee22246507c9#commitcomment-6587616 > > > > > > LGTM, but I lack the environment to test the patch as well. I've asked the > > > github commenter to test. > > > > > > > Thanks -- I should have thought of that! > > I'm sorry for the delay. The reporter confirmed that a similar patch > solved his issue. Since I don't see any negative consequences, I'm going > to push the patch. > > Please note that I haven't been able to reproduce the problem myself as > I don't have access to Windows development environment. Feel free to > revert the patch and yell at me on this list if the patch is not correct > :-)
Pushed to master as: 943e79f4bf7cdcf21471c86e41080fe35154af9d
