[ http://issues.apache.org/jira/browse/XERCESC-1479?page=comments#action_12356410 ]
Tobias Schuette commented on XERCESC-1479: ------------------------------------------ the changes to DOM(Attr/ElementNS)Impl::isSupported look straight forward, but the changes commited to DOMDocumentTypeImpl::isSupported under the hood of this issue are missing a part. correct me if i'm wrong, but DOMDocumentTypeImpl::isSupported should response to queries for '+DOMDocumentTypeImpl' as well, because DOMDocumentTypeImpl* is directly castable. please review. > DOM(Attr/Element) PSVI type info interface isSupported/getInterface > ------------------------------------------------------------------- > > Key: XERCESC-1479 > URL: http://issues.apache.org/jira/browse/XERCESC-1479 > Project: Xerces-C++ > Type: Improvement > Components: DOM > Reporter: Tobias Schuette > Priority: Trivial > > in xercesc/dom/impl/DOM(Attr/ElementNS)Impl.cpp queries for the > "DOMPSVITypeInfo" feature interface are processed by returning the proper > const xercesc::PSVIItem*. > To check interface existence the coresponding call to > DOM(Attr/ElementNS)Impl::isSupported("+DOMPSVITypeInfo", NULL) should return > true, which is actually returning false, because calls are redirected to > xercesc::DOMImplementation::hasFeature. > note the requirement of the "+" before the "DOMPSVITypeInfo" in the call to > DOM(Attr/ElementNS)Impl::isSupported("+DOMPSVITypeInfo", ...) which is > required because xercesc::PSVIItem doesn't implement the xercesc::DOMNode > interface as described in DOM3->Core->DOM Features. > calls to DOM(Attr/ElementNS)Impl::isSupported("DOMPSVITypeInfo", ...) without > "+" should continue returning false; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
