[
https://issues.apache.org/jira/browse/XERCESC-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609695#action_12609695
]
Boris Kolpackov commented on XERCESC-1815:
------------------------------------------
Hi David,
The patch looks good overall. I have a couple of suggestions:
1. Why not make the MemoryManager argument in
XMLTransService::makeNewLCPTTranscoder() default to fgMemoryManager just like
other makeNew* functions in this interface? I am sure most users will want
fgMemoryManager when calling this function.
2. I thought one of the goals of this patch was to make sure XMLMutex is
constructed using the same memory manager as the containing object (it is
rarely created by itself). In this case perhaps we should remove the default
argument (fgMemoryManager) from its c-tor.
What do you think?
Boris
> Propagate MemoryManager into transcoders
> ----------------------------------------
>
> Key: XERCESC-1815
> URL: https://issues.apache.org/jira/browse/XERCESC-1815
> Project: Xerces-C++
> Issue Type: Bug
> Components: Utilities
> Affects Versions: Nightly build (please specify the date)
> Reporter: David Bertoni
> Assignee: David Bertoni
> Attachments: patch.diff
>
>
> This patch propagates a MemoryManager instance into the transcoders, so they
> don't inadvertantly use the global MemoryManager instance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
