Hi David, David Bertoni <[EMAIL PROTECTED]> writes:
> The documentation for these functions says: > > * has length charCount. The result is false if and only if at least > * one of the following is true: > * offset1 is negative. > * offset2 is negative. > * offset1+charCount is greater than the length of str1. > * offset2+charCount is greater than the length of str2. > > So negative offsets immediately signify failure. Since the function is > only called in two places in RegularExpression.cpp, it should be easy to > resolve this. Looking at the implementation, I think you are right. We, however, need to make sure that the code in regex that calls these functions does not pass negative offsets (maybe put the if (offset < 0) check). > I'm happy to start working on many of these changes. It's been > difficult for me to keep Xalan-C warning-free and 64-bit clean because > of all these inconsistencies in Xerces-C, so I'd love to get this fixed > for the 3.0 release. Sounds good. I know this is a big task but it would be great if you could do this sooner rather than later. I was hoping to release the next (and hopefully final) beta in the next couple of weeks and not make any major changes after that until 3.0.0 is out. If you run into any tricky code that requires redesign and you would like to discuss it -- I am available. BTW, I am done with my changes so you can go ahead. Boris -- Boris Kolpackov, Code Synthesis Tools http://codesynthesis.com/~boris/blog Open source XML data binding for C++: http://codesynthesis.com/products/xsd Mobile/embedded validating XML parsing: http://codesynthesis.com/products/xsde --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
