[
https://issues.apache.org/jira/browse/XERCESC-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632811#action_12632811
]
Boris Kolpackov commented on XERCESC-1827:
------------------------------------------
Let me give a bit of a background on how this fix came about. After you
committed your fix I asked Alberto to review it (and was about to do the same
myself) since were were going to release this fix in the final version without
giving the community much chance to test it. Once I started studying the
function I had a really hard time understanding what's going on there. I also
saw a number of potential problems. So I consulted Alberto via IM to see if he
has a better understanding about what's going on. I quickly came to the
conclusion that I am not comfortable releasing that code in this state so I
decided to reimplement it as two separate functions. The whole thing took
probably 30-40 minutes.
I agree using private IM like this is not ideal. However discussing small
things like this on mailing lists and/or Jira takes too much time (what have
taken half an hour over IM would have probably taken several days considering
that a lot of people are living in different time zones). Perhaps we should
setup an IRC channel for Xerces-C++ development with public archives. I wonder
if there is a Apache-recommended way to do this?
As for the limits to changes, as a release manager I have some leeway in
deciding which changes go in and which not. After all, if I make a bad call I
will be the one releasing 3.0.1/3.1.0 to fix it.
> Parser reports error when comment tag is broken up by BinInputStream
> --------------------------------------------------------------------
>
> Key: XERCESC-1827
> URL: https://issues.apache.org/jira/browse/XERCESC-1827
> Project: Xerces-C++
> Issue Type: Bug
> Components: Non-Validating Parser
> Affects Versions: 2.8.0
> Environment: Solaris (SunOS 5.10) i386 SunPRO
> cygwin i386 GCC
> Reporter: Vasantha Crabb
> Fix For: 3.0.0, 2.9.0
>
> Attachments: long.xml, new-test.cc, test.cc
>
>
> If the BinInputStream delivers data to the parser in such a way that the '<',
> '!' and '--' at the start of an XML comment are delivered separately, the
> parser will report the error 'Expected comment or CDATA'. The problem is
> reproducible under Xerces 2.8 on both Solaris i386 with the SunPRO C++
> compiler and cygwin i386 with the GNU C++ compiler.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
