Comment in ReaderMgr::popReader does not match code
---------------------------------------------------

                 Key: XERCESC-1837
                 URL: https://issues.apache.org/jira/browse/XERCESC-1837
             Project: Xerces-C++
          Issue Type: Bug
          Components: Miscellaneous
    Affects Versions: 3.0.1
            Reporter: Ryan Stone
            Priority: Minor


The following is in 
https://svn.apache.org/repos/asf/xerces/c/trunk/src/xercesc/internal/ReaderMgr.cpp

   //
    //  If there was a previous entity, and either the fThrowEOE flag is set
    //  or reader was marked as such, then throw an end of entity.
    //
    if (prevEntity && fThrowEOE || prevReaderThrowAtEnd)
        throw EndOfEntityException(prevEntity, readerNum);

However, the expression in the if statement is equivalent to (prevEntity && 
fThrowEOE) || prevReaderThrowAtEnd, not prevEntity && (fThrowEOE || 
prevReaderThrowAtEnd) as the comment suggests.  I believe that the latter 
expression is what is intended so this is probably a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to