[
https://issues.apache.org/jira/browse/XERCESC-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476019#comment-13476019
]
Svante Signell commented on XERCESC-1998:
-----------------------------------------
Hello, in the submitted patch there was a simple indentation error with the
third last statement:: XMLCh *ret = XMLString::transcode(curDir, manager);
There were four extra spaces in the indentation. Do you need an updated patch?
Another issue is that the changes are made unconditionally. Do you prefer a
test for _POSIX_VERSION >= 200809L for realpath(absPath, NULL) and a
configure.ac function test for getcwd(NULL, 0)? and keep the PATH_MAX version
for systems that don't have these functions? The availability of realpath and
getcwd is already checked in configure.ac.
> Add support for GNU/Hurd by using POSIX.1-2001 and POSIX.1-2008 functions
> -------------------------------------------------------------------------
>
> Key: XERCESC-1998
> URL: https://issues.apache.org/jira/browse/XERCESC-1998
> Project: Xerces-C++
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 3.1.1
> Environment: Debian GNU/Hurd i386
> Reporter: Svante Signell
> Labels: patch
> Fix For: 3.1.1
>
> Attachments: use_posix_fcns.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hello,
> The attached patch solves the build problems for GNU/Hurd due to
> unconditional use of PATH_MAX which is not defined on Hurd (and is optional
> in POSIX). The functions used are realpath (newSrc, NULL) from POSIX.1-2008
> and getcwd (NULL, 0) from glibc-based systems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
