On 22/06/17 19:23, Cantor, Scott wrote:
I've ported essentially all code-related changes and a decent amount of the web 
site changes from the 3.1 branch back up to trunk.

At least one of the original security fixes to the branch apparently caused a regression, 
which I wasn't surprised by. I think there's a separate bug open on that, plus the 
additional security concerns with the bad casts that needs fixing, so the rest is 
"new work" to get a release done, please at least one new feature setting I 
will be adding (the disable DTDs option).

Hope to get most of this done over the next few weeks at the latest.

I haven't pulled any of the old Windows solutions yet, but that's TBD. I'm 
using the cmake-generated version to actually build and test anything.

Hi Scott,

The recent trunk changes broke a few of the unit tests.

https://travis-ci.org/apache/xerces-c/builds/247945962?utm_source=github_status&utm_medium=notification
https://travis-ci.org/apache/xerces-c/builds/247945962?utm_source=github_status&utm_medium=notification

Test failure summary:

- DOMCount (all platforms)
- InitTermTest1 (linux, mingw)
- PParse1 (macos)
- ThreadTest1-9 (cygwin, mingw, msvc)
- ThreadTest2 (macos, cygwin)
- Link error (looks ICU-related)
(and others on Windows with VS2015: DOMTest, XSerializerTest[12], MemHandlerTest1, DOMTypeInfoTest, SAX2?Count[12], SAX2?Print[12], MemParse1?, Redirect1, DOMPrint[1235], StdInParse[12], EnumVal1)

DOMCount looks like it simply needs the added option adding to the expected output for both the perl test script and the cmake expected text file

The link error looks like it's missing a symbol.

The thread test shows up on all Windows compilers, but also shows up on MacOS X.

Not yet looked in detail at the other errors.

Do you need a hand looking at fixing any of these bits?


Regards,
Roger


A summary of the failures follows:

Autotools/Linux:

XERCESC_NLS_HOME=/home/travis/build/apache/xerces-c/autoconf-build/src/ && cd .. && perl scripts/sanityTest.pl 2>&1 | /bin/sed 's/ *[0-9][0-9]* *ms */{timing removed}/' 1> /home/travis/build/apache/xerces-c/autoconf-build/test-results.log
diff test-results.log ../scripts/sanityTest_ExpectedResult.log
623d622
<     -d          Disallow DOCTYPE. Defaults to false.
make: *** [check] Error 1

If the option was added to the output, the expected test data likely needs updating.

and

XERCESC_NLS_HOME=/home/travis/build/apache/xerces-c/autoconf-build/src/ && cd .. && perl scripts/sanityTest.pl 2>&1 | /bin/sed 's/ *[0-9][0-9]* *ms */{timing removed}/' 1> /home/travis/build/apache/xerces-c/autoconf-build/test-results.log
diff test-results.log ../scripts/sanityTest_ExpectedResult.log
623d622
<     -d          Disallow DOCTYPE. Defaults to false.
1147,1153c1146
< 1
< Fatal Error at file /home/travis/build/apache/xerces-c/samples/data/personal.xml, line 2, char 10
<   Message:  invalid document structure
<
< Errors occurred, no output available
<
< Test Failed
---
> 1Test Run Successfully

This one looks like an error?

Autotools/MacOS X:

XERCESC_NLS_HOME=/Users/travis/build/apache/xerces-c/autoconf-build/src/ && cd .. && perl scripts/sanityTest.pl 2>&1 | /usr/bin/sed 's/ *[0-9][0-9]* *ms */{timing removed}/' 1> /Users/travis/build/apache/xerces-c/autoconf-build/test-results.log
diff test-results.log ../scripts/sanityTest_ExpectedResult.log
623d622
<     -d          Disallow DOCTYPE. Defaults to false.
1172,1177c1171
< 3 during parsing: personal.xml
<  Exception message is: invalid document structure
<
< Thread 2: Parse Check sum error on file "personal.xml" for parse # 2. Expected 7352cd96, got 0
< Total number of parses completed is 22.000000.
<    Retry checksum is 0
---
> 3Test Run Successfully
1183,1185c1177
< 9 during parsing: personal.xml
<  Exception message is: invalid document structure
< Test Run Successfully
---
> 9Test Run Successfully
1220a1213
> Test Run Successfully

There are also some stray "9" symbols in here.  Is that intentional?

CMake/Linux:

Linking CXX executable XSTSHarness
../src/libxerces-c-3.2.so: undefined reference to `xercesc_messages_3_1_dat'
collect2: error: ld returned 1 exit status

Build failure.

58: Test command: /home/travis/build/apache/xerces-c/tools/bin/cmake "-DNAME=DOMCount" "-DPROGRAM=/home/travis/build/apache/xerces-c/cmake-build/samples/DOMCount" "-DARGS=" "-DLIBXERCES_C=/home/travis/build/apache/xerces-c/cmake-build/src/libxerces-c-3.2.so" "-DWORKDIR=/home/travis/build/apache/xerces-c/samples/data" "-DSTDIN=" "-DEXPECT_FAIL=TRUE" "-DOBSERVED_DIR=/home/travis/build/apache/xerces-c/cmake-build/samples/observed" "-DEXPECTED_DIR=/home/travis/build/apache/xerces-c/samples/expected" "-DDIFF=/usr/bin/diff" "-DNLS_HOME=/home/travis/build/apache/xerces-c/cmake-build/src" "-P" "/home/travis/build/apache/xerces-c/cmake/RunTest.cmake"
58: Test timeout computed to be: 9.99988e+06
58: -- Running /home/travis/build/apache/xerces-c/cmake-build/samples/DOMCount 58: --- /home/travis/build/apache/xerces-c/cmake-build/samples/observed/DOMCount-exp.log 2017-06-28 13:59:31.069758000 +0000 58: +++ /home/travis/build/apache/xerces-c/cmake-build/samples/observed/DOMCount.log 2017-06-28 13:59:31.065758000 +0000
58: @@ -12,6 +12,7 @@
58:      -n          Enable namespace processing. Defaults to off.
58:      -s          Enable schema processing. Defaults to off.
58: -f Enable full schema constraint checking. Defaults to off.
58: +    -d          Disallow DOCTYPE. Defaults to false.
58:      -locale=ll_CC specify the locale, default: en_US.
58:      -p          Print out names of elements and attributes encountered.
58:      -?          Show this help.
58: CMake Error at /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:71 (message):
58:   Observed output does not match expected output
58: Call Stack (most recent call first):
58: /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:88 (test_command)
58:
58:
58/79 Test #58: DOMCount .........................***Failed    0.01 sec

This is another instance of the expected test data needing an update?

13: Test command: /home/travis/build/apache/xerces-c/tools/bin/cmake "-DNAME=InitTermTest1" "-DPROGRAM=/home/travis/build/apache/xerces-c/cmake-build/tests/InitTermTest" "-DARGS=personal.xml" "-DLIBXERCES_C=/home/travis/build/apache/xerces-c/cmake-build/src/libxerces-c-3.2.so" "-DWORKDIR=/home/travis/build/apache/xerces-c/samples/data" "-DSTDIN=" "-DEXPECT_FAIL=FALSE" "-DOBSERVED_DIR=/home/travis/build/apache/xerces-c/cmake-build/tests/observed" "-DEXPECTED_DIR=/home/travis/build/apache/xerces-c/tests/expected" "-DDIFF=/usr/bin/diff" "-DNLS_HOME=/home/travis/build/apache/xerces-c/cmake-build/src" "-P" "/home/travis/build/apache/xerces-c/cmake/RunTest.cmake"
13: Test timeout computed to be: 9.99988e+06
13: -- Running /home/travis/build/apache/xerces-c/cmake-build/tests/InitTermTest personal.xml 13: CMake Error at /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:46 (message):
13:   Returned failed status 4
13: Call Stack (most recent call first):
13: /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:88 (test_command)
13:
13:
13/79 Test #13: InitTermTest1 ....................***Failed    0.20 sec

MacOS X/CMake:

18: Test command: /Users/travis/build/apache/xerces-c/tools/CMake.app/Contents/bin/cmake "-DNAME=ThreadTest2" "-DPROGRAM=/Users/travis/build/apache/xerces-c/cmake-build/tests/ThreadTest" "-DARGS=-parser=dom;-v=never;-quiet;-threads;10;-time;20;personal.xml" "-DLIBXERCES_C=/Users/travis/build/apache/xerces-c/cmake-build/src/libxerces-c-3.2.dylib" "-DWORKDIR=/Users/travis/build/apache/xerces-c/samples/data" "-DSTDIN=" "-DEXPECT_FAIL=FALSE" "-DOBSERVED_DIR=/Users/travis/build/apache/xerces-c/cmake-build/tests/observed" "-DEXPECTED_DIR=/Users/travis/build/apache/xerces-c/tests/expected" "-DDIFF=/usr/bin/diff" "-DNLS_HOME=/Users/travis/build/apache/xerces-c/cmake-build/src" "-P" "/Users/travis/build/apache/xerces-c/cmake/RunTest.cmake"
18: Test timeout computed to be: 9.99988e+06
18: -- Running /Users/travis/build/apache/xerces-c/cmake-build/tests/ThreadTest -parser=dom -v=never -quiet -threads 10 -time 20 personal.xml 18: CMake Error at /Users/travis/build/apache/xerces-c/cmake/RunTest.cmake:46 (message):
18:   Returned failed status Segmentation fault
18: Call Stack (most recent call first):
18: /Users/travis/build/apache/xerces-c/cmake/RunTest.cmake:88 (test_command)
18:
18:
18/79 Test #18: ThreadTest2 ......................***Failed    0.05 sec

72: Test command: /Users/travis/build/apache/xerces-c/tools/CMake.app/Contents/bin/cmake "-DNAME=PParse1" "-DPROGRAM=/Users/travis/build/apache/xerces-c/cmake-build/samples/PParse" "-DARGS=personal.xml" "-DLIBXERCES_C=/Users/travis/build/apache/xerces-c/cmake-build/src/libxerces-c-3.2.dylib" "-DWORKDIR=/Users/travis/build/apache/xerces-c/samples/data" "-DSTDIN=" "-DEXPECT_FAIL=FALSE" "-DOBSERVED_DIR=/Users/travis/build/apache/xerces-c/cmake-build/samples/observed" "-DEXPECTED_DIR=/Users/travis/build/apache/xerces-c/samples/expected" "-DDIFF=/usr/bin/diff" "-DNLS_HOME=/Users/travis/build/apache/xerces-c/cmake-build/src" "-P" "/Users/travis/build/apache/xerces-c/cmake/RunTest.cmake"
72: Test timeout computed to be: 9.99988e+06
72: -- Running /Users/travis/build/apache/xerces-c/cmake-build/samples/PParse personal.xml 72: CMake Error at /Users/travis/build/apache/xerces-c/cmake/RunTest.cmake:46 (message):
72:   Returned failed status 1
72: Call Stack (most recent call first):
72: /Users/travis/build/apache/xerces-c/cmake/RunTest.cmake:88 (test_command)
72:
72:
72/79 Test #72: PParse1 ..........................***Failed    0.04 sec

Cygwin/CMake:

17: Test command: /usr/bin/cmake.exe "-DNAME=ThreadTest1" "-DPROGRAM=/cygdrive/c/projects/build/tests/ThreadTest.exe" "-DARGS=-parser=sax;-v=never;-quiet;-threads;10;-time;20;personal.xml" "-DLIBXERCES_C=/cygdrive/c/projects/build/src/libxerces-c-3.2.a" "-DWORKDIR=/cygdrive/c/projects/xerces-c/samples/data" "-DSTDIN=" "-DEXPECT_FAIL=FALSE" "-DOBSERVED_DIR=/cygdrive/c/projects/build/tests/observed" "-DEXPECTED_DIR=/cygdrive/c/projects/xerces-c/tests/expected" "-DDIFF=/usr/bin/diff.exe" "-DNLS_HOME=/cygdrive/c/projects/build/src" "-DCYGWIN=1" "-P" "/cygdrive/c/projects/xerces-c/cmake/RunTest.cmake"
17: Test timeout computed to be: 9.99988e+06
17: -- Running /cygdrive/c/projects/build/tests/ThreadTest.exe -parser=sax -v=never -quiet -threads 10 -time 20 personal.xml 17: CMake Error at /cygdrive/c/projects/xerces-c/cmake/RunTest.cmake:46 (message):
17:   Returned failed status 255
17: Call Stack (most recent call first):
17:   /cygdrive/c/projects/xerces-c/cmake/RunTest.cmake:88 (test_command)
17:
17:

MinGW/CMake:

InitTermTest1, ThreadTest1-9, DOMCount

MS Visual Studio 2015/CMake:

"C:\projects\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\projects\build\samples\CreateDOMDocument.vcxproj" (default target) (3) ->
"C:\projects\build\src\xerces-c.vcxproj" (default target) (4) ->
(Link target) ->
ICUMsgLoader.obj : error LNK2019: unresolved external symbol __imp_xercesc_messages_3_1_dat referenced in function "public: __cdecl xercesc_3_2::ICUMsgLoader::ICUMsgLoader(wchar_t const * const)" (??0ICUMsgLoader@xercesc_3_2@@QEAA@QEB_W@Z) [C:\projects\build\src\xerces-c.vcxproj] C:\projects\build\src\Release\xerces-c_3_2.dll : fatal error LNK1120: 1 unresolved externals [C:\projects\build\src\xerces-c.vcxproj]

Previous builds were also failing ThreadTest1-9

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org

Reply via email to