[
https://issues.apache.org/jira/browse/XERCESC-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118289#comment-16118289
]
Scott Cantor commented on XERCESC-2113:
---------------------------------------
Sorry, forgot to fix the include issue last night. We *really* need a
consistent internal include set, if it wasn't so let in the cycle I'd do it.
Anway, I thought I was depending on a macro, not on SIZE_MAX directly, I
conditionally defined it, didn't I? I pointed it to ULONG_MAX in the case where
size_t didn't exist.
> Base64.cpp missing config.h include
> -----------------------------------
>
> Key: XERCESC-2113
> URL: https://issues.apache.org/jira/browse/XERCESC-2113
> Project: Xerces-C++
> Issue Type: Bug
> Components: Build, Utilities
> Affects Versions: 3.2.0
> Reporter: Roger Leigh
>
> {{{
> 13:04:43
> /opt/hudson/workspace/OME-FILES-CPP-DEV-merge-superbuild/BUILD_TYPE/Release/node/brill/build/xerces-source/src/xercesc/util/Base64.cpp:149:14:
> error: use of undeclared identifier 'XERCES_SIZE_MAX'
> 13:04:43 else if (XERCES_SIZE_MAX - inputLength < 2) {
> 13:04:43 ^
> }}}
> I think this is because of a missing stdint.h include. This is provided by
> config.h, but there's no config.h include in Base64.cpp. Other platforms
> must be getting this via an indirect include.
> Note that this also has other portability implications (though they don't
> need tackling right now). Using size_t implies using SIZE_MAX, but SIZE_MAX
> requires stdint.h. stdint.h was previously optional, with fallbacks used if
> not present, but this makes it effectively mandatory, making all of the other
> integer portability logic redundant. i.e. we could just require
> stdint.h/cstdint unconditionally and drop all of the other logic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
