On 10/27/2017 01:35 PM, Scott Morgan wrote: > Just tried building 3.2.0 via the CMake process with VC2010. All worked > well, but it appears to be missing the XERCES_MFC_SUPPORT define that > covers some stuff in util/XMemory.* needed for Visual C++'s debug app > builds. > > Did I miss out a step in the CMake generation?
If anyone's interested, here's a patch against trunk to get things working. Pretty simple stuff. Added a #cmakedefine to the autoconfig file and in the top level CMakeLists.txt added in a conditional to spot MSVC. Scott
Index: CMakeLists.txt =================================================================== --- CMakeLists.txt (revision 1813972) +++ CMakeLists.txt (working copy) @@ -116,6 +116,10 @@ include(XercesIconvConst) include(XercesLFS) +if(MSVC) + option(XERCES_MFC_SUPPORT "MFC Debug support" ON) +endif() + # Generate headers configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/config.h.cmake.in Index: src/xercesc/util/Xerces_autoconf_config.hpp.cmake.in =================================================================== --- src/xercesc/util/Xerces_autoconf_config.hpp.cmake.in (revision 1813972) +++ src/xercesc/util/Xerces_autoconf_config.hpp.cmake.in (working copy) @@ -56,6 +56,7 @@ #cmakedefine XERCES_HAVE_INTRIN_H 1 #cmakedefine XERCES_HAVE_EMMINTRIN_H 1 #cmakedefine XERCES_INCLUDE_WCHAR_H 1 +#cmakedefine XERCES_MFC_SUPPORT #define XERCES_S16BIT_INT @XERCES_S16BIT_INT@ #define XERCES_S32BIT_INT @XERCES_S32BIT_INT@
--------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org