[ 
https://issues.apache.org/jira/browse/XERCESC-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372011#comment-16372011
 ] 

Roger Leigh commented on XERCESC-2138:
--------------------------------------

I can only assume that this code originated when namespaces were still 
optional, since it seems to be using the XSConstants class as a namespace 
equivalent.  It looks like it's safe as it stands, but it is issuing a warning 
quite legitimately.

 

Could we simply switch to using a namespace?

 

As a wider change, could we make namespaces mandatory across the board?

> class xercesc_3_2::XSConstants only defines private constructors and has no 
> friends
> -----------------------------------------------------------------------------------
>
>                 Key: XERCESC-2138
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2138
>             Project: Xerces-C++
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.2.0
>            Reporter: Johnny Willemsen
>            Priority: Trivial
>
> When compiling xercesc-3.2.0 with mingw-64 gcc 4.9.3 on Windows we get a lot 
> of warnings, for example:
> class xercesc_3_2::XSConstants' only defines private constructors and has no 
> friends
>  In file included from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSObject.hpp:26:0,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSTypeDefinition.hpp:25,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.hpp:25,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/validators/datatype/DatatypeValidator.hpp:32,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLAttr.hpp:28,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLValidator.hpp:25,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/sax2/SAX2XMLReader.hpp:27,
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                  from 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/samples/src/SAX2Print/SAX2Print.cpp:28:
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc] 
> C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSConstants.hpp:56:24:
>  warning: 'class xercesc_3_2::XSConstants' only defines private constructors 
> and has no friends [-Wctor-dtor-privacy]
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]  class XMLPARSER_EXPORT XSConstants 
> Gandalf_win10_x86_64_01(administrator@172.16.2.213) 
> [pkg_xercesc:windows-pkg-xercesc]                         ^



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org

Reply via email to