[
https://issues.apache.org/jira/browse/XERCESC-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966740#comment-16966740
]
Scott Cantor commented on XERCESC-2179:
---------------------------------------
Even if int were used, that's still 32-bits, same as long is. The code I see in
the svn repo is using long, unless there'a a second spot where int is being
used, but either is 32-bits of data, matching a DWORD.
The code I see is passing the address of a 32-bit variable as an LPDWORD. That
is correct code.
You keep claiming this thing is a "far/long DWORD". There is no such thing as a
"far" anything, that is not a thing anymore. FAR or far define to nothing in
the Windows headers. There is a type of DWORDLONG, but these APIs don't take
that type. So that is also not an issue here.
I'm prepared to accept that LPDWORD is being turned into something I don't
think it is if you can find the macro expansion and point it out, but AFAIK,
LPDWORD is just DWORD*, which is in turn equivalent to unsigned long* or
unsigned int* on x64.
So no, nothing you're posting is convincing me Albert is wrong.
If I were you, I would undo the DWORD change as an experiment, but maybe leave
in the rest of the patch related to the buffer size. Perhaps that is the more
relevant fix, Albert's assumptions notwithstanding.
> access violation in win32transservice.cpp with 64 bit compile
> -------------------------------------------------------------
>
> Key: XERCESC-2179
> URL: https://issues.apache.org/jira/browse/XERCESC-2179
> Project: Xerces-C++
> Issue Type: Bug
> Components: DOM
> Affects Versions: 3.2.2
> Reporter: martin goodall
> Assignee: Alberto Massari
> Priority: Blocker
> Fix For: 3.2.3
>
> Attachments: Win32TransService.cpp
>
>
> calls to ::Reg... to get registry info are passing in stack variables that
> are 8 bytes long into functions that overwrite 16 bytes, causing memory
> overwrite and very random segs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
