[
https://issues.apache.org/jira/browse/XERCESC-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005378#comment-17005378
]
Scott Cantor commented on XERCESC-2131:
---------------------------------------
Because nobody has posted any proof of a significant impact and even if there
was one, the original code was *broken*. Whether it was faster is immaterial
when it was *wrong*.
Improving the performance of correct code is (usually) always possible with
enough work or with a redesign, but that doesn't make fixing the bug a
regression. Sometimes fixes hurt performance.
The proposed patch in the other issue that avoids RTTI may be reasonable, but a
redesign of the classes is not in scope for me when there is no performance
problem to resolve for any of my projects. No other maintainers have expressed
any willingness to take it on.
> DOMParentNode::appendChildFast is not efficient due to multiple dynamic_casts
> -----------------------------------------------------------------------------
>
> Key: XERCESC-2131
> URL: https://issues.apache.org/jira/browse/XERCESC-2131
> Project: Xerces-C++
> Issue Type: Improvement
> Components: DOM
> Affects Versions: 3.2.0
> Reporter: Piotr Borkowski
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
