rleigh-codelibre commented on a change in pull request #3: XERCESC-2185 XERCESC-2186 XERCESC-2187 - Solaris, HP-UX and AIX URL: https://github.com/apache/xerces-c/pull/3#discussion_r371022728
########## File path: src/xercesc/util/Janitor.hpp ########## @@ -155,8 +155,10 @@ private : }; +#if defined(__GNUC__) || (! defined(_AIX) && ! defined(__hpux) && ! defined(__sun)) Review comment: Is the `defined(__GNUC__)` necessary? Isn't that already taken care of by the other part of the or, along with LLVM, MSVC etc.? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
