[
https://issues.apache.org/jira/browse/XERCESC-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052450#comment-17052450
]
Roger Leigh commented on XERCESC-2156:
--------------------------------------
The provided patch switches from the CMake FindCURL script to using pkg-config
by default. I'm not sure that's the correct approach, but would be happy to
discuss further.
If FindCURL is not finding the static version of the CURL library, I think the
best course of action would be to contribute the necessary fix for this module
to CMake upstream and/or the CURL upstream if it's a CURL-provided config
module.
The patch as provided is using pkg-config by default and then falling back to
FindCURL as a fallback. If we were to go with this approach, I think that we
should be doing it the other way around and falling back to pkg-config, since
FindCURL should be the canonical way to find it with CMake.
> fix static linking with curl
> ----------------------------
>
> Key: XERCESC-2156
> URL: https://issues.apache.org/jira/browse/XERCESC-2156
> Project: Xerces-C++
> Issue Type: Bug
> Components: Build
> Affects Versions: 3.2.0, 3.2.1, 3.2.2
> Reporter: Fabrice Fontaine
> Assignee: Roger Leigh
> Priority: Minor
> Fix For: 3.2.3
>
> Attachments: 0001-fix-static-linking-with-curl.patch
>
>
> When curl is statically built with openssl support, xerces needs to
> link with openssl libraries so use pkg_check_modules to get any
> needed dependencies
> Fixes:
> -
> http://autobuild.buildroot.org/results/29ca90fff2c8e38f2edf7240eca3aa3fe7397c45
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
