[ https://issues.apache.org/jira/browse/XERCESC-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052461#comment-17052461 ]
Scott Cantor edited comment on XERCESC-2138 at 3/6/20, 2:52 AM: ---------------------------------------------------------------- I'm fine creating a branch if there's work desired to be done, I'll raise that with the PMC just as a sanity check and then look at branching 3.2 off and leaving master open. I do not expect sufficient work to happen that maintaining the branch would be a big problem. GitHub's terms of service require indemnifying them for IPR lawsuits, so that's untenable without indemnification insurance. I have worked on projects that IBM has sued before, so it is not a theoretical issue for me. I cannot commit code to GitHub and I made that clear when the proposal was made. I do some non-coding work there but never anything with risky IPR. If there were a way to accept the PR but have the commit made to gitbox, I would be fine with that. (Edited to say, I didn't realize the patches came from Roger originally since the issue was filed by someone else, so I assume the contribution itself is fine.) was (Author: canto...@osu.edu): I'm fine creating a branch if there's work desired to be done, I'll raise that with the PMC just as a sanity check and then look at branching 3.2 off and leaving master open. I do not expect sufficient work to happen that maintaining the branch would be a big problem. GitHub's terms of service require indemnifying them for IPR lawsuits, so that's untenable without indemnification insurance. I have worked on projects that IBM has sued before, so it is not a theoretical issue for me. I cannot commit code to GitHub and I made that clear when the proposal was made. I do some non-coding work there but never anything with risky IPR. If there were a way to accept the PR but have the commit made to gitbox, I would be fine with that. But a patch this size also probably needs a proper license or contribution agreement too. PRs may be easy to apply, but that doesn't make them "allowable", and that can be a problem too. But I haven't looked at the patch; if it's got a license attached that's fine. > Xerces-C++ should use C++98 features and remove pre-Standard workarounds > ------------------------------------------------------------------------ > > Key: XERCESC-2138 > URL: https://issues.apache.org/jira/browse/XERCESC-2138 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Affects Versions: 3.2.0 > Reporter: Johnny Willemsen > Assignee: Roger Leigh > Priority: Trivial > Attachments: 0001-Make-XSConstants-a-namespace.patch, > 0002-Drop-XERCES_HAS_CPP_NAMESPACE-check.patch, > 0003-Drop-XERCES_STD_NAMESPACE-check.patch, > 0004-Drop-XERCES_NO_NATIVE_BOOL-check.patch, > 0005-Drop-XERCES_NEW_IOSTREAMS-check.patch, > 0006-Use-cstdlib-in-place-of-stdlib.h.patch, > 0007-Use-cstdio-in-place-of-stdio.h.patch, > 0008-Use-cstring-in-place-of-string.h.patch, > 0009-Remove-use-of-strings.h.patch, > 0010-Use-std-in-place-of-XERCES_STD_QUALIFIER.patch, > 0011-Drop-const-workarounds.patch, 0012-Drop-inline-workarounds.patch, > 0013-Drop-unused-volatile-workarounds.patch, > 0014-Replace-XERCES_CPP_NAMESPACE-macros-with-real-namesp.patch > > > When compiling xercesc-3.2.0 with mingw-64 gcc 4.9.3 on Windows we get a lot > of warnings, for example: > class xercesc_3_2::XSConstants' only defines private constructors and has no > friends > In file included from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSObject.hpp:26:0, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/validators/datatype/DatatypeValidator.hpp:32, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLAttr.hpp:28, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/XMLValidator.hpp:25, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/sax2/SAX2XMLReader.hpp:27, > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] from > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/samples/src/SAX2Print/SAX2Print.cpp:28: > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] > C:/cygwin64/home/administrator/build-ad87109bfff0765f4dd8cf4943b04d16a4070fea/xerces-c-3.2.0/src/xercesc/framework/psvi/XSConstants.hpp:56:24: > warning: 'class xercesc_3_2::XSConstants' only defines private constructors > and has no friends [-Wctor-dtor-privacy] > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] class XMLPARSER_EXPORT XSConstants > Gandalf_win10_x86_64_01(administrator@172.16.2.213) > [pkg_xercesc:windows-pkg-xercesc] ^ -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org