wsfulton opened a new pull request, #58: URL: https://github.com/apache/xerces-c/pull/58
There are three related aspects to this merge request: ### 1. Improved NetAccessor internal error message A bug to display the URL is now shown in the thrown exception where used in the MacOSURLAccessCF (NetAcc_InternalError) and Curl NetAccessors (new NetAcc_InternalError exception message). ### 2. Improved unhandled Curl error messages libcurl has 101 error codes, see [CURLcode in curl.h](https://github.com/curl/curl/blob/88727f7ed048f828e6cf0b2a0981e51e61143c81/include/curl/curl.h#L643-L645). Xerces handles just a handful of these. Instead of just displaying an internal error, these messages are now informative and include both the libcurl error code and the description of the error from libcurl. For example using the NetAccessorTest: ``` $ ./tests/NetAccessorTest file:///notexist.xml Exception during test: libcurl error in NetAccessor for URL file:///notexist.xml '37:Couldn't read a file:// file' ``` This change was needed to help understand the bug filed at https://issues.apache.org/jira/browse/XERCESC-2250. The new error message related to that bug is now: ``` $ ./tests/NetAccessorTest file:///mnt/c/xerces/xerces-c/doc/program-dom.xml Exception during test: libcurl error in NetAccessor for URL file:///mnt/c/xerces/xerces-c/doc/program-dom.xml '23:Failed writing received data to disk/application' ``` Previously the above two unhelpfully just showed: ``` $ ./tests/NetAccessorTest file:///mnt/c/xerces/xerces-c/doc/program-dom.xml Exception during test: internal error in NetAccessor ``` ### 3. Updates to NLS Xlat code generator - Fixes for compiling with newer visual c++. - Update Xlat README file with missing information and corrections and to make regenerating the files easier by providing the actual copy commands needed for updating the code. - Add missing and additional warning suppression in the generated code for `-Wctor-dtor-privacy`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
