Hi Rob,
Thanks for checking that. This was a bug in the Xerces-C++ CMake build
which got carried over to the Xalan-C++ CMake build. I fixed this some
time back for Xerces and didn't realise it was still being applied for
Xalan. I've opened a ticket (XALANC-807) and a PR to fix this, and some
other cosmetic CMake details, and tested it with VS2019. The changes
are here: https://github.com/apache/xalan-c/pull/30/files
I'll make an RC2 tomorrow with this fix included.
Kind regards,
Roger
On 29/05/2020 19:16, Rob Conde wrote:
I will double check, but just to clarify I was pointing to:
set_target_properties(xalan-c PROPERTIES OUTPUT_NAME
"Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
and in XalanDll.cmake you have:
if(MSVC)
set(CMAKE_DEBUG_POSTFIX "D")
endif()
so it seems that the output name will unconditionally have a D
postfixed on windows.
Rob
------------------------------------------------------------------------
*From:* Roger Leigh <rle...@codelibre.net>
*Sent:* Friday, May 29, 2020 1:22 PM
*To:* c-users@xalan.apache.org <c-users@xalan.apache.org>; Rob Conde
<rob.co...@ai-solutions.com>; xalan-...@apache.org <xalan-...@apache.org>
*Subject:* Re: Xalan-C++ 1.12 release candidate 1
Hi Rob,
I don't think this is a bug. It only applies to debug builds, and
I've used this configuration in quite a few open source projects
without trouble including libtiff, xerces-c and others. If you use
e.g. a multi-configuration generator like for Visual Studio, then the
DEBUG_POSTFIX applies to the debug variant(s) and not to the release
variant(s).
Please could you run a release build with -DCMAKE_BUILD_TYPE=Release
and verify that the library name does not contain the suffix?
Kind regards,
Roger
On 29/05/2020 13:47, Rob Conde wrote:
Hey Again Roger,
Ok - now I think I found a straight-up bug (let me know if you
want to handle this in a github issue instead).
set_target_properties(xalan-c PROPERTIES OUTPUT_NAME
"Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME
"Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX"D")
You're always appending the CMAKE_DEBUG_POSTFIX, which means even the
release dlls/libs are postfixed with D.
Rob
------------------------------------------------------------------------
*From:* Rob Conde <rob.co...@ai-solutions.com>
<mailto:rob.co...@ai-solutions.com>
*Sent:* Friday, May 29, 2020 8:22 AM
*To:* xalan-...@apache.org <mailto:xalan-...@apache.org>
<xalan-...@apache.org> <mailto:xalan-...@apache.org>;
c-users@xalan.apache.org <mailto:c-users@xalan.apache.org>
<c-users@xalan.apache.org> <mailto:c-users@xalan.apache.org>
*Subject:* Re: Xalan-C++ 1.12 release candidate 1
Hey Roger,
First thanks for your work! This release is actually very timely
for me. I'm running into an issue when building against a shared
xerces library. When the msgcreator is run it crashes because it
can't find the xerces dll. I'm gonna try to handle this externally by
updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the
platform - but this might be better handled in the xalan cmake
itself. I'm not entirely sure the conventions for this scenario.
Thanks,
Rob
------------------------------------------------------------------------
*From:* Roger Leigh <rle...@codelibre.net> <mailto:rle...@codelibre.net>
*Sent:* Sunday, May 24, 2020 6:26 PM
*To:* xalan-...@apache.org <mailto:xalan-...@apache.org>
<xalan-...@apache.org> <mailto:xalan-...@apache.org>;
c-users@xalan.apache.org <mailto:c-users@xalan.apache.org>
<c-users@xalan.apache.org> <mailto:c-users@xalan.apache.org>
*Subject:* Xalan-C++ 1.12 release candidate 1
Dear all,
I have tagged and made a prerelease of 1.12 which can be obtained here:
https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
The above link includes the release notes, links to .tar.gz and .zip
archives, and the signed release tag. The full documentation is at:
https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
The current iteration fixes all of the major problems I was aware of,
and it's now ready for wider testing. I would be very grateful if
all Xalan-C++ users reading this could take the time to build and
test it with your own code, and report back any successes or
failures. If any problems are found, we can investigate and fix them
in an RC2, or defer to 1.13 if appropriate. If we're confident that
this is release-worthy, then I'll call for a vote and we can make the
first Xalan-C++ release for nearly 8 years!
Kind regards,
Roger Leigh
