Hi Rob,
Thanks again for testing and finding this.
I'm afraid this isn't a new issue. It was broken with 1.11 as well, and
I only spotted it myself last week when testing various Windows
configurations. I created XALANC-802
(https://issues.apache.org/jira/browse/XALANC-802). Because it's not a
1.12 regression, I've assigned it to the 1.13 release. Since 1.12 will
be the first release in quite some time, and with a new build system, I
expect we'll get more minor issues reported once people start packaging
it on various platforms, so I think we'll have at least one point
release in the following weeks, so I'll get it done as soon as 1.12 is
released. I just had to draw a line between 1.12 and 1.13, and since no
one reported this in 8 years, decided to defer it for a few weeks.
Regards,
Roger
On 31/05/2020 21:45, Rob Conde wrote:
Hey Roger,
Static builds seem broken on windows. There's this error:
C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\xalan-c\src\xalanc\XalanDOM\XalanDOMInit.cpp(27,47):
error C2491: 'xalanc_1_12::XalanDOMInit::s_initCounter': definition of
dllimport static data member not allowed
[C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\src\xalanc\xalan-c.vcxproj]
and then lots of warnings like:
C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\xalan-c\src\xalanc\XalanDOM\XalanDOMImplementation.cpp(27,1):
warning C4273:
'xalanc_1_12::XalanDOMImplementation::XalanDOMImplementation':
inconsistent dll linkage
[C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\src\xalanc\xalan-c.vcxproj]
C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\xalan-c\src\xalanc\XalanDOM\XalanDOMImplementation.hpp(49,5):
message : see previous definition of '{ctor}'
[C:\cn\xalan-c\1.12-rc2\rwc\stable\build\99dbd0ec50a6fb8c00cb677dbfbfb9115890da29\src\xalanc\xalan-c.vcxproj]
I think the problem is in DOMSupportDefinitions.hpp:
#if defined(XALAN_BUILD_DLL)
#define XALAN_DOMSUPPORT_EXPORT XALAN_PLATFORM_EXPORT
#define XALAN_DOMSUPPORT_EXPORT_FUNCTION(T)
XALAN_PLATFORM_EXPORT_FUNCTION(T)
#else
#define XALAN_DOMSUPPORT_EXPORT XALAN_PLATFORM_IMPORT
#define XALAN_DOMSUPPORT_EXPORT_FUNCTION(T)
XALAN_PLATFORM_IMPORT_FUNCTION(T)
#endif
I didn't fully track it down, but I don't think if you want to import
if XALAN_BUILD_DLL is not defined. I assume this is used for the
exe's, but of course it needs to account when building a static
library as well.
Again, thanks for your work!
Rob
------------------------------------------------------------------------
*From:* Roger Leigh <rle...@codelibre.net>
*Sent:* Sunday, May 31, 2020 6:12 AM
*To:* xalan-...@apache.org <xalan-...@apache.org>;
c-users@xalan.apache.org <c-users@xalan.apache.org>
*Subject:* Xalan-C++ 1.12 release candidate 2
Dear all,
I have tagged and made a second release candidate:
https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC2
The above link includes the release notes, links to .tar.gz and .zip
archives, and the signed release tag. The full documentation is
at:https://apache.github.io/xalan-c/
RC2 includes:
* XALANC-807: Do not add library debug postfix unconditionally with MSVC
* XALANC-799: Remove use of winres.h in XalanMsgLib.rx
* A cosmetic grouping of documentation targets into a Documentation
folder in Visual Studio
Many thanks for everyone who tested and provided feedback for RC1. I
would be grateful if you could retest with RC2 and report back if the
problems are fixed. I would also be grateful if anyone who has not yet
tested RC1 to take the time to test with RC2. I would like to make
the final release this week, and I would appreciate if you could
report back the results of testing by the end of Tuesday at the latest.
Kind regards,
Roger
