Hello Joel, as for me there isn't any problem so far except the rounding one, i improved my latest patch in order to fix it as much as possible (can't get totally rid of it... e.g if the invoice is in CHF, the accounting in EUR and the payment in USD!): now it's not using the debit/credit columns anymore but the amount_currency one if the currency of the payment is the same as the invoice one.
Then it solves all the problem, isn't it? :) ** Patch added: "residual_amount_invoice_v2.patch" https://bugs.launchpad.net/openobject-addons/+bug/511104/+attachment/1754186/+files/residual_amount_invoice_v2.patch -- You received this bug notification because you are a member of C2C OERPScenario, which is subscribed to the OpenERP Project Group. https://bugs.launchpad.net/bugs/511104 Title: Pay invoice wizard regression in foreign currency Status in OpenObject Addons Modules: In Progress Bug description: Hi ! There is a regression introduce by commit 2537 into addons on the pay invoice wizard ! The amount in currency are wrongly computed !!! Here the test case : Background: Given I am loged as admin user with password admin used And the company currency is set to EUR And the following currency rate settings are: |code|rate|name| |EUR|1.000|01-01-2009| |CHF|1.644|01-01-2009| |CHF|1.500|09-09-2009| |CHF|0.6547|10-10-2009| |USD|1.3785|01-01-2009| And a cash journal in USD exists And a cash journal in CHF exists And a cash journal in EUR exists Scenario: make_and_validate_payments_with_pay_invoice_wizard Given I have recorded on the 1 jan 2009 a supplier invoice (in_invoice) of 1000,0 CHF without tax called MySupplierInvoicePayWizard When I press the validate button Then I should see the invoice MySupplierInvoicePayWizard open When I call the Pay invoice wizard And I partially pay 200.0 CHF.- on the 10 jan 2009 Then I should see a residual amount of 800.0 CHF.- When I call the Pay invoice wizard And I partially pay 200.0 USD.- on the 11 jan 2009 Then I should see a residual amount of 561.48 CHF.- CRASH HERE expected: 561.48, got: 600.0 (using ==) When I call the Pay invoice wizard And I partially pay 200.0 EUR.- on the 12 jan 2009 Then I should see a residual amount of 232.68 CHF.- When I call the Pay invoice wizard And I completely pay the residual amount in CHF on the 13 sep 2009 Then I should see a residual amount of 0.0 CHF.- And I should see the invoice MySupplierInvoicePayWizard paid THANKS TO REVERT THIS COMMIT ASAP !! Regards, _______________________________________________ Mailing list: https://launchpad.net/~c2c-oerpscenario Post to : [email protected] Unsubscribe : https://launchpad.net/~c2c-oerpscenario More help : https://help.launchpad.net/ListHelp
