Hi,

  I went back to the Oct 13 code and added:

424a425,436
>       String extraQuery = "alvin1=value1";
>       String file;
>       if (url.toString().indexOf("?") > 0) {
>         file = url.getFile() + "&" + extraQuery;
>       } else {
>         file = url.getFile() + "?" + extraQuery;
>       }
> 
>       url = new URL(url.getProtocol(), url.getHost(),
>             url.getPort(), file);
> 
>       logger.debug("alvin2: url=" + url);

to HttpClientHelper.java

The testStatusCode failed for me.



This lead to a thought.

new methods to support passing Cactus parameters in the query string

   WebRequest.addCactusParameter(String theName, String theValue)

   ServletURL.getQueryStringParameter(String theQueryString
        , String theParameter)


If we changed getQueryStringParameter to
getCactusParameter(HttpServletRequest theRequest, String theParameter)

we could do the following:

* provide an option for the user to choose which way to send Cactus
parameters:
  a) normal through 'addParameter'
  b) through query string as the previous patch tried
  c) through 'addHeader'

  This is done in WebRequest and WebRequest.addCactusParameter


* in ServletURL.getCactusParameter
  a) check query string for cactus parameter
  b) fall back to 'getParameter'
  c) fall back to 'getHeader'


  The default could be "normal through 'addParameter'".

  This might provide the most backward compatibility and still allow
for unrestricted access to the doPost output stream.

  Is this getting too complex for the problem?

  Comments and suggestions are welcome.

  I will try out the ideas over the weekend.

Alvin.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to