vmassol     2002/10/18 09:02:40

  Modified:    Eclipse-Plugin/src/java/org/apache/cactus/eclipse/launcher
                        CactusLaunchConfiguration.java
  Log:
  * line must not be longer than 80 chars
  * removed NLS comments
  * add brackets for one line blocks
  
  Revision  Changes    Path
  1.4       +43 -31    
jakarta-cactus/Eclipse-Plugin/src/java/org/apache/cactus/eclipse/launcher/CactusLaunchConfiguration.java
  
  Index: CactusLaunchConfiguration.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-cactus/Eclipse-Plugin/src/java/org/apache/cactus/eclipse/launcher/CactusLaunchConfiguration.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- CactusLaunchConfiguration.java    18 Oct 2002 15:44:22 -0000      1.3
  +++ CactusLaunchConfiguration.java    18 Oct 2002 16:02:40 -0000      1.4
  @@ -86,27 +86,30 @@
   import org.eclipse.jdt.launching.sourcelookup.JavaSourceLocator;
   
   /**
  - * @author Julien Ruaux
  - *
  - * This class contains the configuration for the VM that will actually launch the 
cactus tests.
  + * This class contains the configuration for the VM that will actually launch 
  + * the cactus tests.
    * 
    * @version $Id$
  + * @author <a href="mailto:jruaux@;octo.com">Julien Ruaux</a>
  + * @author <a href="mailto:vmassol@;apache.org">Vincent Massol</a>
    */
   public class CactusLaunchConfiguration extends JUnitLaunchConfiguration
   {
  -
  -    public static final String ID_CACTUS_APPLICATION = 
"org.apache.cactus.eclipse.launchconfig"; //$NON-NLS-1$
  +    public static final String ID_CACTUS_APPLICATION = 
  +        "org.apache.cactus.eclipse.launchconfig";
   
       /**
        * @see 
org.eclipse.debug.core.model.ILaunchConfigurationDelegate#launch(ILaunchConfiguration, 
String, ILaunch, IProgressMonitor)
        */
  -    public void launch(ILaunchConfiguration configuration, String mode,
  +    public void launch(ILaunchConfiguration Configuration, String Mode,
           ILaunch launch, IProgressMonitor pm) throws CoreException
       {
           IJavaProject javaProject = getJavaProject(configuration);
           if ((javaProject == null) || !javaProject.exists())
           {
  -            
abort(JUnitMessages.getString("JUnitBaseLaunchConfiguration.error.invalidproject"), 
null, IJavaLaunchConfigurationConstants.ERR_NOT_A_JAVA_PROJECT); //$NON-NLS-1$
  +            abort(JUnitMessages.getString(
  +                "JUnitBaseLaunchConfiguration.error.invalidproject"), null, 
  +                IJavaLaunchConfigurationConstants.ERR_NOT_A_JAVA_PROJECT);
           }
   
           IType testType = getTestType(configuration, javaProject);
  @@ -116,7 +119,10 @@
   
           if (runner == null)
           {
  -            
abort(MessageFormat.format(JUnitMessages.getString("JUnitBaseLaunchConfiguration.error.novmrunner"),
 new String[] { install.getId()}), null, 
IJavaLaunchConfigurationConstants.ERR_VM_RUNNER_DOES_NOT_EXIST); //$NON-NLS-1$
  +            abort(MessageFormat.format(JUnitMessages.getString(
  +                "JUnitBaseLaunchConfiguration.error.novmrunner"),
  +                new String[] { install.getId()}), null, 
  +                IJavaLaunchConfigurationConstants.ERR_VM_RUNNER_DOES_NOT_EXIST);
           }
   
           File workingDir = verifyWorkingDirectory(configuration);
  @@ -177,33 +183,36 @@
        * @see 
org.eclipse.jdt.internal.junit.launcher.JUnitBaseLaunchConfiguration#createVMRunner(ILaunchConfiguration,
 IType[], int, String)
        */
       protected VMRunnerConfiguration createVMRunner(
  -        ILaunchConfiguration configuration,
  -        IType[] testTypes,
  -        int port,
  -        String runMode)
  -        throws CoreException
  +        ILaunchConfiguration configuration, IType[] testTypes, int port, 
  +        String runMode) throws CoreException
       {
           String[] classPath = createClassPath(configuration, testTypes[0]);
  -        VMRunnerConfiguration vmConfig = new 
VMRunnerConfiguration("org.eclipse.jdt.internal.junit.runner.RemoteTestRunner", 
classPath); //$NON-NLS-1$
  +        VMRunnerConfiguration vmConfig = new VMRunnerConfiguration(
  +            "org.eclipse.jdt.internal.junit.runner.RemoteTestRunner", 
  +            classPath);
   
           Vector argv = new Vector(10);
  -        argv.add("-port"); //$NON-NLS-1$
  +        argv.add("-port");
           argv.add(Integer.toString(port));
  -        //argv("-debugging");
  -        argv.add("-classNames"); //$NON-NLS-1$
  +        argv.add("-classNames");
   
  -        if (keepAlive(configuration)
  +        if (keepAlive(configuration) 
               && runMode.equals(ILaunchManager.DEBUG_MODE))
  -            argv.add(0, "-keepalive"); //$NON-NLS-1$
  -
  +        {
  +            argv.add(0, "-keepalive");
  +        }
  +        
           for (int i = 0; i < testTypes.length; i++)
  +        {
               argv.add(testTypes[i].getFullyQualifiedName());
  -
  +        }
  +        
           String[] args = new String[argv.size()];
           argv.copyInto(args);
           vmConfig.setProgramArguments(args);
   
  -        // We set a VM argument related to the Cactus framework (QQQ : get this 
from the plugin preference page)
  +        // We set a VM argument related to the Cactus framework (QQQ : get 
  +        // this from the plugin preference page).
           String[] vmArgs = { "-Dcactus.contextURL=http://localhost:8081/test"; };
           vmConfig.setVMArguments(vmArgs);
           return vmConfig;
  @@ -216,10 +225,8 @@
        * @return String[]
        * @throws CoreException
        */
  -    private String[] createClassPath(
  -        ILaunchConfiguration configuration,
  -        IType type)
  -        throws CoreException
  +    private String[] createClassPath(ILaunchConfiguration configuration, 
  +        IType type) throws CoreException
       {
           URL url = JUnitPlugin.getDefault().getDescriptor().getInstallURL();
           String[] cp = getClasspath(configuration);
  @@ -232,15 +239,20 @@
               if (inDevelopmentMode)
               {
                   // assumption is that the output folder is called bin!
  -                classPath[0] = Platform.asLocalURL(new URL(url, "bin")).getFile(); 
//$NON-NLS-1$
  -            } else
  +                classPath[0] = Platform.asLocalURL(
  +                    new URL(url, "bin")).getFile();
  +            } 
  +            else
               {
  -                classPath[0] = Platform.asLocalURL(new URL(url, 
"junitsupport.jar")).getFile(); //$NON-NLS-1$
  +                classPath[0] = Platform.asLocalURL(
  +                    new URL(url, "junitsupport.jar")).getFile();
               }
  -        } catch (MalformedURLException e)
  +        } 
  +        catch (MalformedURLException e)
           {
               JUnitPlugin.log(e); // TO DO abort run and inform user
  -        } catch (IOException e)
  +        } 
  +        catch (IOException e)
           {
               JUnitPlugin.log(e); // TO DO abort run and inform user
           }
  
  
  

--
To unsubscribe, e-mail:   <mailto:cactus-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:cactus-dev-help@;jakarta.apache.org>

Reply via email to