Hi Julien,

Some comments:

1/ The interface must provide all needed parameters to the
implementation classes. ATM there are no parameters passed which makes
virtually impossible to provide an implementation. The Tomcat
implementation is "cheating" :-) as it is using hardcoded values.

2/ As a consequence of 1/ there should be a class containing all
container information (such as ContainerInfo or ContainerDetail):
- home directory
- port to use
- arbitrary parameters

3/ The API should be modified to include needed parameters:

    void start(ContainerInfo info) throws CoreException;
    void deploy(String contextPath, URL deployableObject(war or ear),
Credential credentials) throws CoreException;
    void undeploy(String contextPath, Credential credentials) throws
CoreException;
    void stop(ContainerInfo info) throws CoreException;

where Credential is a simple class containing username and password.

4/ Implementation package should be separated from interface package.

5/ We also need a way to create the war!

-Vincent


--
To unsubscribe, e-mail:   <mailto:cactus-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:cactus-dev-help@;jakarta.apache.org>

Reply via email to