Hi Chris, +1 to all your suggestions! Please fell free to modify the code! :-)
Thanks -Vincent > -----Original Message----- > From: Christopher Lenz [mailto:[EMAIL PROTECTED] > Sent: 11 March 2003 09:36 > To: Cactus Developers List > Subject: Re: cvs commit: jakarta- > cactus/integration/ant/src/java/org/apache/cactus/integration/ant > WebMergeTask.java WebMerge.java > > Hi Vincent, > > [EMAIL PROTECTED] wrote: > > vmassol 2003/03/04 09:41:47 > > > > Added: > integration/ant/src/test/org/apache/cactus/integration/ant > > TestWebMerge.java > > > integration/ant/src/java/org/apache/cactus/integration/ant > > WebMergeTask.java WebMerge.java > > Log: > > Added beginning of an automatic merge of web.xml files > > Nice! Have been using XDoclet for that until now, and will need to find > out if this task can replace that, but it looks good. > > Not a big fan of the attribute names though: something more "standard" > like srcfile/destfile/mergefile would be better IMHO, although > "mergefile" or "override" is a bit hard to find a good name for. > > The (implied) name of the task itself is also a bit off IMHO (Oh man, > I'm becoming a naming fascist ;-) ). How about <mergewebxml> or > <webxmlmerge> instead? > > I'd also like to add support for the following: > > <webmerge original="web.xml" output="merged-web.xml"> > <redirector type="servlet" url="/test/ServletRedirector"/> > <redirector type="filter" url="/test/FilterRedirector"/> > <redirector type="jsp" url="/test/JspRedirector"/> > </webmerge> > > ... to avoid having to maintain an extra web.xml file for Cactus. > > What do you think? > > -- > Christopher Lenz > /=/ cmlenz at gmx.de > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
