cmlenz 2003/06/11 09:17:26
Modified: integration/ant/src/java/org/apache/cactus/integration/ant/container
AbstractContainer.java GenericContainer.java
ContainerFactory.java
Log:
Fix some "design for extension" violations
Revision Changes Path
1.6 +4 -4
jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/AbstractContainer.java
Index: AbstractContainer.java
===================================================================
RCS file:
/home/cvs/jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/AbstractContainer.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- AbstractContainer.java 14 May 2003 18:18:41 -0000 1.5
+++ AbstractContainer.java 11 Jun 2003 16:17:26 -0000 1.6
@@ -245,7 +245,7 @@
/**
* @see Container#setAntTaskFactory
*/
- public void setAntTaskFactory(AntTaskFactory theFactory)
+ public final void setAntTaskFactory(AntTaskFactory theFactory)
{
this.antTaskFactory = theFactory;
}
@@ -261,7 +261,7 @@
/**
* @see Container#setLog
*/
- public void setLog(Log theLog)
+ public final void setLog(Log theLog)
{
this.log = theLog;
}
@@ -314,7 +314,7 @@
*
* @return The default filter chain
*/
- protected FilterChain createFilterChain()
+ protected final FilterChain createFilterChain()
{
ReplaceTokens.Token token = null;
FilterChain filterChain = new FilterChain();
1.6 +3 -3
jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/GenericContainer.java
Index: GenericContainer.java
===================================================================
RCS file:
/home/cvs/jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/GenericContainer.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- GenericContainer.java 13 May 2003 10:11:03 -0000 1.5
+++ GenericContainer.java 11 Jun 2003 16:17:26 -0000 1.6
@@ -74,7 +74,7 @@
*
* @version $Id$
*/
-public class GenericContainer extends AbstractContainer
+public final class GenericContainer extends AbstractContainer
{
// Inner Classes -----------------------------------------------------------
@@ -84,7 +84,7 @@
* supports either an Ant target to delegate to, or a list of nested tasks
* that are to be executed in order to perform the operation.
*/
- public class Hook implements TaskContainer
+ public final class Hook implements TaskContainer
{
// Instance Variables --------------------------------------------------
1.3 +2 -2
jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/ContainerFactory.java
Index: ContainerFactory.java
===================================================================
RCS file:
/home/cvs/jakarta-cactus/integration/ant/src/java/org/apache/cactus/integration/ant/container/ContainerFactory.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ContainerFactory.java 12 May 2003 09:03:51 -0000 1.2
+++ ContainerFactory.java 11 Jun 2003 16:17:26 -0000 1.3
@@ -109,7 +109,7 @@
* @return The instantiated container
* @throws BuildException If there was a problem creating the container
*/
- public Container createContainer(String theName) throws BuildException
+ public final Container createContainer(String theName) throws BuildException
{
Container container = null;
try
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
