> -----Original Message-----
> From: Lesiecki Nicholas [mailto:[EMAIL PROTECTED]
> Sent: 22 June 2003 11:28
> To: Cactus Developers List
> Subject: RE: cvs commit: jakarta-
> cactus/framework/src/java/share/org/apache/cactus
> AbstractWebServerTestCase.java
> 
> 
> > >   -        if (getWrappedTest() != this)
> > >   +        if (wrappingATest())
> >
> > The refactoring is good but I don't much like the wrappingATest()
method
> > name... What about hasWrappedTest() or something like this (I like
to
> > prefix methods that return a boolean with "is" or "has")?
> >
> 
> My suggestions:
> 
> isWrapping()
> isWrapper()
> isTestWrapper()
> 
> I agree in general about booleans.

Cool. Pick the one you like most! :-)

Thanks
-Vincent

> 
> Cheers,
> Nick
> > Thanks
> > -Vincent
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to