Bizarrely, this does not fail on my box. Maybe if I were to run against a another container... In any case, I made a change that I hope should fix it. And the tests still pass. I'm making this change on the plane, so I can't DL another container. Let me know if it works...
Cheers, Nick On 6/23/03 5:45 AM, "Vincent Massol" <[EMAIL PROTECTED]> wrote: > Yeah, I know it fails! I have just added the tests that shows it fail! > It was previously throwing a NPE. > > I guess this error must have been introduced by Nick's recent changes. > I've spent several hours yesterday trying to track it, but I haven't > found the culprit and in the end I had other things to do... :-( > > It needs to be fixed ASAP of course. > > Thanks > -Vincent > >> -----Original Message----- >> From: news [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Lenz >> Sent: 23 June 2003 12:39 >> To: [EMAIL PROTECTED] >> Subject: Re: cvs commit: jakarta-cactus/samples/servlet/src/test- >> cactus/share/org/apache/cactus/sample/unit TestHttpSession.java >> >> Vincent, have you run the tests with this assertion? >> It fails for me on every container I tried: >> - jboss3x >> - orion1x >> - orion2x >> - resin2x >> - tomcat3x >> - tomcat4x >> - tomcat5x >> >> -chris (not a container ;-) ) >> >> [EMAIL PROTECTED] wrote: >>> vmassol 2003/06/22 10:14:43 >>> >>> Modified: samples/servlet/src/test- >> cactus/share/org/apache/cactus/sample/unit >>> TestHttpSession.java >>> Log: >>> Session cookie should not be null >>> >>> Revision Changes Path >>> 1.5 +2 -1 jakarta-cactus/samples/servlet/src/test- >> cactus/share/org/apache/cactus/sample/unit/TestHttpSession.java >>> >>> Index: TestHttpSession.java >>> > =================================================================== >>> RCS file: /home/cvs/jakarta-cactus/samples/servlet/src/test- >> cactus/share/org/apache/cactus/sample/unit/TestHttpSession.java,v >>> retrieving revision 1.4 >>> retrieving revision 1.5 >>> diff -u -r1.4 -r1.5 >>> --- TestHttpSession.java 26 May 2003 12:15:14 -0000 1.4 >>> +++ TestHttpSession.java 22 Jun 2003 17:14:43 -0000 1.5 >>> @@ -125,6 +125,7 @@ >>> public void beginCreateSessionCookie(WebRequest theRequest) >>> { >>> HttpSessionCookie sessionCookie = >> theRequest.getSessionCookie(); >>> + assertNotNull("Session cookie should not be null", >> sessionCookie); >>> theRequest.addCookie(sessionCookie); >>> } >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
