-----Original Message----- From: news [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Lenz Sent: 23 June 2003 13:05 To: [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-
cactus/framework/src/java/share/org/apache/cactus/client/connector/http
HttpUtil.java JdkConnectionHelper.java HttpClientConnectionHelper.java AbstractConnectionHelper.java
[snip]
This seems to add pretty fragile functionality (query string
manipulation
doeswith encoding etc) to Cactus that should already be provided by Commons-HttpClient. Why are we not using HttpClient for this? Wherethis code come from and why do we need it?
+1 if this code exists in HttpClient. I'm just not aware of it.
Well, HttpClient probably doesn't have exactly *this* code :-)
We seem to have a lot of stuff that is only required to support both JDK-provided as well as HttpClient-provided HTTP connectivity. If we dropped the JdkConnectionHelper, we might be able to drop stuff like the classes CookieUtil/UrlUtil/HttpUtil, by using the HttpClient-API directly. Although you can configure Cactus to use the JdkConnectionHelper via a system property, that is not documented AFAICT, so the JdkConnectionHelper is probably not used anywhere.
Another thought: we could make Commons-HttpClient an optional dependancy by falling back to the JDK connection helper if HttpClient is not found. In that case, we'd want to keep JdkConnectionHelper, but still have the HttpClientConnectionHelper use the HttpClient API more directly...
-- Christopher Lenz /=/ cmlenz at gmx.de
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
