Sure, I agree, but currently there is a bug that is more a problem than the confusion it may be causing. If the user uses a custom config and has a port different than 8080, it fails...
We should of course, make our default jboss config use the defined port... :-) -Vincent > -----Original Message----- > From: Christopher Lenz [mailto:[EMAIL PROTECTED] > Sent: 06 August 2003 20:54 > To: Cactus Developers List > Subject: Re: cvs commit: jakarta-cactus/documentation/docs/xdocs > changes.xml > > [EMAIL PROTECTED] wrote: > > vmassol 2003/08/06 10:37:29 > > > > Modified: > integration/ant/src/java/org/apache/cactus/integration/ant/container/jbo ss > > JBoss3xContainer.java > > documentation/docs/xdocs changes.xml > > Log: > > Added the ability to define the JBoss port that will be used > > in the Ant integration to poll if the JBoss server is up and > > running. Note: This value will not modify the port of the > > default JBoss configuration (it is still 8080). However, it > > is useful for users who have defined their own JBoss > > configuration and are using a port other than 8080. > > Okay, but this is rather confusing. I didn't omit the port attribute out > of confusion, but because it would have behaved completely different > than for the other containers: i.e. it works *only* on an already > running instance. > > I'm not sure I'm in favor of this change :-/ > > -chris > > > Revision Changes Path > > 1.7 +20 -1 jakarta- > cactus/integration/ant/src/java/org/apache/cactus/integration/ant/contai ne > r/jboss/JBoss3xContainer.java > > > > Index: JBoss3xContainer.java > > =================================================================== > > RCS file: /home/cvs/jakarta- > cactus/integration/ant/src/java/org/apache/cactus/integration/ant/contai ne > r/jboss/JBoss3xContainer.java,v > > retrieving revision 1.6 > > retrieving revision 1.7 > > diff -u -r1.6 -r1.7 > > --- JBoss3xContainer.java 19 Jun 2003 19:56:56 -0000 1.6 > > +++ JBoss3xContainer.java 6 Aug 2003 17:37:28 -0000 1.7 > > @@ -126,6 +126,25 @@ > > this.config = theConfig; > > } > > > > + /** > > + * Sets the port that will be used to poll the server to verify > if > > + * it is started. This is needed for the use case where the user > > + * has defined his own JBoss configuration by using the > > + * [EMAIL PROTECTED] #setConfig(String)} call and has defined a port other > > + * than the default one. > > + * > > + * Note: This value is not yet used to set the port > > + * to which the container will listen to. The reason is that this > is > > + * hard to implement with JBoss and nobody had the courage to > implement > > + * it yet... > > + * > > + * @param thePort The port to set > > + */ > > + public final void setPort(int thePort) > > + { > > + this.port = thePort; > > + } > > + > > // Container Implementation ------------------------------------- > ----------- > > > > /** > > > > > > > > 1.122 +8 -0 jakarta- > cactus/documentation/docs/xdocs/changes.xml > > > > Index: changes.xml > > =================================================================== > > RCS file: /home/cvs/jakarta- > cactus/documentation/docs/xdocs/changes.xml,v > > retrieving revision 1.121 > > retrieving revision 1.122 > > diff -u -r1.121 -r1.122 > > --- changes.xml 14 Jul 2003 20:30:12 -0000 1.121 > > +++ changes.xml 6 Aug 2003 17:37:28 -0000 1.122 > > @@ -77,6 +77,14 @@ > > </action> > > --> > > <release version="1.6" date="in CVS"> > > + <action dev="VMA" type="add" due-to="Florin Vancea" due-to- > email="[EMAIL PROTECTED]"> > > + Added the ability to define the JBoss port that will be > used > > + in the Ant integration to poll if the JBoss server is up > and > > + running. Note: This value will not modify the port of the > > + default JBoss configuration (it is still 8080). However, it > > + is useful for users who have defined their own JBoss > > + configuration and are using a port other than 8080. > > + </action> > > </release> > > > > <release version="1.5" date="14 July 2003"> > > > -- > Christopher Lenz > /=/ cmlenz at gmx.de > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
