Hi Chris,

> -----Original Message-----
> From: Christopher Lenz [mailto:[EMAIL PROTECTED]
> Sent: 25 October 2003 20:24
> To: Cactus Developers List
> Subject: Re: Test earfile for cactus orion2x
> 
> Vincent Massol wrote:
> > Hi Perry,
> >
> > Thanks for your EAR. I think I have found the problem. In your
> > application.xml you specify a web-uri but no context-root element.
I'm
> > not sure this is allowed. However, I've modified Cactus to support
this
> > use case. If no context-root is specified, Cactus will now use the
> > web-uri without a possible leading slash and without the extension.
> 
> It's not allowed AFAICT:
> 
>    http://java.sun.com/dtd/application_1_3.dtd
>    http://java.sun.com/j2ee/dtds/application_1_2.dtd
> 
> Both specify that the 'context-root' element is a mandatory child
> element of the 'web' element.

Yes, that's how I read it too.

> 
> I don't think we should support invalid deployment descriptors, Cactus
> being primarily a tool for quality control ;-) 

Good point! I wanted to be lenient on this but you're right.

> So I'd prefer to see the
> change backed out, personally. 

I've reverted the change.

> We could also think about putting the XML
> parser that is used to parse the descriptors in <cactifywar> and
> <cactus> in validating mode, which would catch such errors and
hopefully
> report a human-understandable error.

Not sure it is needed really as we're also catching these errors in our
code.

Thanks for catching this.
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to