Hi Nicolas, Thanks for those patches. I haven't had a look yet (I'm still on holiday till the 8th of August and I'm trying to do things other than coding... ;-)). As soon as I'm back I'll check them out (I may possibly do it earlier if I get bored before the end of the holidays).
As for Strutstescase, I'm unsure. The point is that the strutstestcase project is a separate project. It has nothing to do with the Cactus project (apart from the fact that it extends Cactus). I have no knowledge of it either. Thus I am loathe to include a dependency to it as there'll be stuff to fix or modify and I won't be able to do it. Thus the sample will become unsupported and will be broken (that's also the problem of OSS projects accepting all contributions without maintainers for them). In view of all this I think it makes more sense that you sample belongs to the strutstestcase project itself rather than to the Cactus project. What do you think? Thanks -Vincent > -----Original Message----- > From: Nicolas Chalumeau [mailto:[EMAIL PROTECTED] > Sent: jeudi 29 juillet 2004 21:47 > To: [EMAIL PROTECTED] > Subject: Re: [jira] Updated: (CACTUS-132) Allow cactus plugin to include > some resources > > Hi Vincent > > Look after for my comment : > > > Hi Nicolas, > > > >> -----Original Message----- > >> From: [EMAIL PROTECTED] [mailto:[EMAIL <mailto:%5BEMAIL> PROTECTED] > >> trelaze.com] > >> Sent: mercredi 28 juillet 2004 10:37 > >> To: [EMAIL PROTECTED] > >> Subject: Re: [jira] Commented: (CACTUS-132) Allow cactus plugin to > >> include > >> some resources > >> > >> Ok pas de probleme. Do you want I modify one of the samples > >> application to > >> illustrate that UC or is there a better way to do some test case in the > >> maven plugin. > > > > > > It's hard to write unit tests for maven plugins. I'm not sure what we > > can do > > to test your new feature (resource copying). > > I am curious on how to do this so I could try to do it if you want. I > think that using the plugin:test goal should work to call cactus task in > the sample applications with the reactor or multiproject. The call could > be iterate on each type of server... Of course I don't have all the > servers that cactus support but I could enable a plugin test for tomcat > and jboss and make it extensible by using a property list of server. > > > We could of course modify one > > of the existing sample so that it does some resource copying but I can't > > think of a valid use case that would also be meaningful as an example. > > I add a new sample. It is meaningful as it is a logon struts action > (that allways fail but...). It is kind of thing to be reuse in a webapp > so can be provide in a jar... In that uc when you test this kind of jar > you don't want to include some resources like db access param in the > final jar artifact. > > I use strutstestcase because some people looks for example on how cactus > work with it in the user list. > > Nicolas > > > > > Thanks > > -Vincent > > > >> > >> Nicolas > >> > >> > >> > >> > >> > >> [EMAIL PROTECTED] > >> 27/07/2004 20:40 > >> > >> > >> Pour : [EMAIL PROTECTED] > >> cc : > >> Objet : [jira] Commented: (CACTUS-132) Allow cactus plugin to > >> include some > >> resources > >> > >> > >> The following comment has been added to this issue: > >> > >> Author: Vincent Massol > >> Created: Tue, 27 Jul 2004 11:40 AM > >> Body: > >> Cool. Thanks Nicolas. Could you please also add the associated > >> changes for > >> properties.xml, changes.xml and plugin.properties? (and also mabye for > >> project.xml to add you as a contributor :-))? > >> --------------------------------------------------------------------- > >> View this comment: > >> http://issues.apache.org/jira/browse/CACTUS- > >> 132?page=comments#action_36900 > >> > >> --------------------------------------------------------------------- > >> View the issue: > >> http://issues.apache.org/jira/browse/CACTUS-132 > >> > >> Here is an overview of the issue: > >> --------------------------------------------------------------------- > >> Key: CACTUS-132 > >> Summary: Allow cactus plugin to include some resources > >> Type: New Feature > >> > >> Status: Unassigned > >> Priority: Minor > >> > >> Project: Cactus > >> Components: > >> Maven Integration > >> > >> Assignee: > >> Reporter: Nicolas Chalumeau > >> > >> Created: Tue, 20 Jul 2004 5:18 AM > >> Updated: Tue, 27 Jul 2004 11:40 AM > >> > >> Description: > >> In a project I produce a jar artifact. I have a webapp in my > >> src/test/webapp directory. I need to include some resources in the > >> war for > >> the cactus test as junit does. > >> > >> As Vincent answers me : > >> > Is there a way to include build resources and test resources in the > >> > webapp during a cactus test ? > >> > >> ... I guess the Cactus > >> plugin could copy some resources. However, the resources that Cactus > >> would > >> copy (during the cactifywar step) would need to be defined as > properties > >> (and not in the POM as there's not way currently to extend the POM and > I > >> think we shouldn't reuse the junit resources which are for pure JUnit > >> tests). > >> > >> > >> > >> --------------------------------------------------------------------- > >> JIRA INFORMATION: > >> This message is automatically generated by JIRA. > >> > >> If you think it was sent incorrectly contact one of the administrators: > >> http://issues.apache.org/jira/secure/Administrators.jspa > >> > >> If you want more information on JIRA, or have a bug to report see: > >> http://www.atlassian.com/software/jira > >> > >> > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
