> Here is a condensed patch with all the changes, plus a > test case and additional check if the directory exists.
Cool :) > I haven't commit it though, for a reason: once this new > properties gets through, users will expect a mechanismo > to include/exclude files, probably using wildcards > (like * and **). I think it could be easy to do by adding includes and exclude in the ant:copy task. > So, I change the property to cactus.resources.dirs, > in a way that would allow us to add new properties in the future > (like cactus.resources.includes and cactus.resources.excludes). > Note that this is not as straightfoward as having this info in > the POM, as we cannot have individual includes/excludes for each > directory. Why not using this king of thing ? cactus.resources.dirs=logResources,otherResources cactus.resources.logResources=src/main/resources/log cactus.resources.logResources.includes=**.xml,**.dtd cactus.resources.logResources.excludes=**old.* cactus.resources.otherResources=src/main/resources/other cactus.resources.otherResources.includes=**.xml,**.dtd cactus.resources.otherResources.excludes=**old.* If you want i can take a look at this and send you the result ... > Anyway, I will commit (or not) the changes once I get some feedback > on this comment. Of course I am for applying this patch as I really need this fonctionnality and actully we use a modify plugin.jelly so I need to do the modification for new release (no one actually :) ) > -- Felipe > > PS: another improvement that could be made would be not relying on > maven.build.dest and including the resources directly from inside > the <cactifywar> tag. Good approach. But is this fonctionnality could be use with <cactifyear> too ? > But I'm not sure if that would work (besides > I haven't the spare cycles to check it right now :-) Nicolas, --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
