On Thu, 4 Nov 2004 16:55:02 +0100, "Vincent Massol" <[EMAIL PROTECTED]> wrote:
> I don't like too much the test case names (test*) as they don't represent > anything. Couldn't we replace them with what they are doing? For example > instead of test06, I would prefer testIncludeResourcesInCactifiedWar. What > do you think? I'm fine with that - I just followed the pattern used in another maven plugins. Anyway, another think that we could improve is cleaning up the target directory after the test. > Same comment for the descriptive items in the project.xml. For test06 it > currently says: > > <id>test-cactus-maven-plugin-06</id> > <name>Simple project</name> > <description>Test for CACTUS-132</description> > > I think the following would be better: > > <id>test-cactus-maven-plugin-testIncludeResourceInCactifiedWar</id> > <name>Test project</name> > <description>Test inclusion of resources in the cactified > WAR</description> > What do you think? What about leaving the <description> as you proposed and using <shortDescription>Test case for CACTUS-132</shortDescription>? > Also, there are problems of extra empty lines in almost all the files in > test*. Could you please check this out? What files? The xml files? BTW, there is some sort of checkstyle task to check that, right? (I just realized it yesterday, when I was trying to build dist-12 :-( -- Felipe --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
