> -----Original Message----- > From: Felipe Leme [mailto:[EMAIL PROTECTED] > Sent: jeudi 4 novembre 2004 21:20 > To: Cactus Developers List > Subject: Re: Trying to understand CACTUS-132 > > Hi Vincent, > > On Thu, 4 Nov 2004 19:26:55 +0100, "Vincent Massol" <[EMAIL PROTECTED]> > wrote: > > > I'm still trying to understand CACTUS-132. I can see the code that was > added > > to copy some resources files in maven.build.dest but I don't understand > how > > it finds its way in the cactifywar task. > > I'm not sure if I reviewed the code carefully, I think I just added the > test cases (and assumed the code was ok, based in your comment - > http://nagoya.apache.org/jira/browse/CACTUS-132#action_36900). > > > > I was expecting to see some new <classes> element in the <cactifywar> > but > > it's not there it seems. > > Yes, that would be a more elegant solution. In fact, I mentioned that too, > but I wasn't sure if it would work (as I'm not that familiar with the ant > tasks). From http://nagoya.apache.org/jira/browse/CACTUS-132#action_54564: > > ] PS: another improvement that could be made would be not relying on > maven.build.dest and including the > ] resources directly from inside the <cactifywar> tag. But I'm not sure if > that would work (besides I haven't the > ] spare cycles to check it right now :-) > > > Also the cactifywar task extends the WAR task so we can use the > <classes> > > element to put any file in the WEB-INF/classes directory. > > Ok, makes sense. Hopefully we can change the implementation and the final > result will be the same (i.e., the tasks will pass!). > > > Have I got something wrong? :-) > I think you got it right and we got it wrong :-( > Sorry... >
No worries provided it is fixed! :-) I should also have paid more attention to the issue ;-) Thanks -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
