Thanks Magnus. A superb patch again :-) I have just a single question: I've not looked hard yet but I've noticed there is a CactusWar class that you have added that extends the CactifyWarTask Ant task. However it's missing some javadoc and I'm not sure what it is for. Also, it doesn't seem to be adding new features to the CactifyWarTask in term of Ant task. It seems to be storing the context. Do you think it should be an extension of the CactifyWarTask class or could it be modeled differently?
Here are some tasks that we'll have to perform in the future to completely finish the CactifyEAR integration (in addition to the ones you've already entered in JIRA): - refactor the maven integration to use the new <cactifyear> task - document the cactifyear task on the web site (in the same manner that it's done for the cactifywar one) Thanks -Vincent > -----Original Message----- > From: Magnus Grimsell (JIRA) [mailto:[EMAIL PROTECTED] > Sent: lundi 14 f�vrier 2005 11:09 > To: [email protected] > Subject: [jira] Updated: (CACTUS-190) cactifyear > > [ http://issues.apache.org/jira/browse/CACTUS-190?page=history ] > > Magnus Grimsell updated CACTUS-190: > ----------------------------------- > > Attachment: cactus-patch3.txt > > This is a first basic implementation of the cactifyear ant task. It > probably needs more features and junit tests, but this is a start. I > wasn't sure of how the javadoc version tag should look on the new files so > I improvised and checkstyle didn't complain. [snip] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
