> -----Original Message----- > From: Felipe Leme [mailto:[EMAIL PROTECTED] > Sent: mardi 26 avril 2005 12:54 > To: Cactus Developers List > Subject: RE: Problem in maven plugin tests? > > On Tue, 2005-04-26 at 11:39 +0200, Vincent Massol wrote: > > Hmm... No, I really don't like doing copy-paste! :-) > > Ok, agreed. > > > What are the problems for not reusing more of the EAR plugin? > > I never looked deeply at this issue (as Homer would say, "It was that > way when I got there" :-),
:-) Sure, it's natural to take shortcuts from time to time. It only increases our "technical debt" for the future (http://www.martinfowler.com/bliki/TechnicalDebt.html). Now is the time to pay it back! ;-) > but I guess the problem is that we need to > include our generated war inside the ear, and the EAR plugin does not > allow that (it only includes the dependencies). Then I guess we could refactor the EAR plugin to support this in some manner... [OT] I've had a quick look at the EAR plugin and I don't understand the way it's implemented which I find very complex. Do you know why we don't use the <zipfileset prefix=""> Ant tag instead of copying around dependencies in a temporary directory? [snip] Thanks -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]