Thanks Sebb,

I have just added the final modifiers.

2008/5/19 sebb <[EMAIL PROTECTED]>:

> On 19/05/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > Author: ptahchiev
> >  Date: Mon May 19 03:09:50 2008
> >  New Revision: 657779
> >
> >  URL: http://svn.apache.org/viewvc?rev=657779&view=rev
> >  Log:
> >  minor fix.
> >
> >  Modified:
> >
> jakarta/cactus/trunk/integration/maven2/src/main/java/org/apache/cactus/maven2/mojos/CactifyWarMojo.java
> >
> >  Modified:
> jakarta/cactus/trunk/integration/maven2/src/main/java/org/apache/cactus/maven2/mojos/CactifyWarMojo.java
> >  URL:
> http://svn.apache.org/viewvc/jakarta/cactus/trunk/integration/maven2/src/main/java/org/apache/cactus/maven2/mojos/CactifyWarMojo.java?rev=657779&r1=657778&r2=657779&view=diff
> >
>  
> ==============================================================================
> >  ---
> jakarta/cactus/trunk/integration/maven2/src/main/java/org/apache/cactus/maven2/mojos/CactifyWarMojo.java
> (original)
> >  +++
> jakarta/cactus/trunk/integration/maven2/src/main/java/org/apache/cactus/maven2/mojos/CactifyWarMojo.java
> Mon May 19 03:09:50 2008
> >  @@ -158,7 +158,7 @@
> >       * Dependencies to be included in the WEB-INF/lib folder.
> >       * @parameter
> >       */
> >  -    private List libDependencies;
> >  +    private List libDependencies = new ArrayList();
>
> Can this be made final?
>
> Would be better for thread safety.
>
> >
> >      /**
> >       * Should we install the cactified archive in the local maven repo?
> >  @@ -331,6 +331,7 @@
> >                         tempLocation.deleteOnExit();
> >
> >                         //Now add all of the additional lib files.
> >  +
> >                         for (Iterator iter =
> libDependencies.iterator();iter.hasNext();)
> >                         {
> >                                 org.apache.cactus.maven2.mojos.Dependency
> dependency =
> >
> >
> >
> >  ---------------------------------------------------------------------
> >  To unsubscribe, e-mail: [EMAIL PROTECTED]
> >  For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


-- 
Regards, Petar!
Karlovo, Bulgaria.

EOOXML Objections
http://www.grokdoc.net/index.php/EOOXML_objections

Public PGP Key at:
https://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0x19658550C3110611
Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611

Reply via email to