----- Original Message -----
From: "Lesiecki Nick" <[EMAIL PROTECTED]>
To: "Vincent Massol" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Sunday, September 09, 2001 8:14 PM
Subject: Comments on the FilterChainWrapper Class
> Vincent,
>
> I've taken a look at the FilterChainWrapper class. As far
> as I can tell, the setMockFilterChain method appears to be
> redundant. If users want to provide a mocked
> implementation, they can pass their own mock directly to
> the doFilter(request, response, chain) method on the Filter
> under test. Since the interface is so small, the only
> behavior of the wrapper is to call the doFilter on either
> the original filterChain or the mocked filterChain--a
> behavior that test cases can easily replicate themselves.
>
You are completely right ! Although it means implementing 2 additional
methods, this is the correct way to do it ! I'll remove the
FilterChainWrapper right now ... Thanks for catching this before the release
:)
I've just committed the changes in CVS.
> Did you have a reason for defining it the way you did?
nope, just missing a pair-partner ... :)
>
> Cheers,
>
> Nick
-Vincent
