> -----Original Message----- > From: J. B. Rainsberger [mailto:[EMAIL PROTECTED] > Sent: 28 November 2003 23:55 > To: Cactus Users List > Subject: Code Review (Re: "You must either set location or path on > <pathelement>" Exception Message) > > Vincent Massol wrote: > > > File toolsJar = new File(javaHome + "/../lib/tools.jar"); > > I think this could and /should/ be > > new File(javaHome, "../lib/tools.jar");
Are you confident javaHome will always contain a trailing "/"? In any case, I think this whole section should be rewritten as it does not support MAC OS and we could verify whether tools.jar is already in the executing classloaders and take it from there if it is (not sure how easy it is). Thanks -Vincent > -- > J. B. Rainsberger, > Diaspar Software Services > http://www.diasparsoftware.com :: +1 416 791-8603 > Let's write software that people understand > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
