Hi Jean.
Thanks for reviewing. I've taken all of your suggestions.
On 11/02/09 12:37, jeanm wrote:
> DefValProc.py
>
> line 824: Can you fix up the english on that line?
Thanks. One "given" deleted. (Must have been in a "given" mood at the
time I wrote that...)
>
> lib/install_utils/ManifestServ.py:
> line 448: Couldn't this be "if not pre_request or"? I think that would
> be easier to understand.
Yes. Thanks. Changed.
> line 495,522: similar to above.
Yup. Changed.
>
> TreeAcc.py:
> line 747: Would "and found_nodes" be more python like?
Done.
> line 1154: How about if not is_unique: ?
Done.
Thanks,
Jack
>
> Jean
>
> Jack Schwartz wrote:
>> Hi everyone.
>>
>> Here are 2.4 -> 2.6 and PEP8 changes for install_utils used by DC and
>> other parts of the install mosaic. Please review. (Clay, are you
>> available for this?)
>>
>> http://cr.opensolaris.org/~schwartz/091101.1/webrev/index.html
>>
>> All files achieve a 10 by pylint, with the following caveats:
>> - usr/src/lib/install_utils/ManifestServ.py: --disable-msg=C0321
>> which thinks the try of try/except/finally is two statements on one line
>> - TreeAcc.py: --disable-msg=E1103 since pylint thinks some datatypes
>> are lists when they are not.
>> These are documented in the code.
>>
>> I have tested all changed files:
>> - tested parser files by executing all functions of TreeAcc module
>> - tested many different nodepaths to exercise ENParser module
>> - testing both good and error cases for validation and default setting
>> - verified ManifestRead socket interfaces
>> - verified finalizer called modules with args correctly
>>
>> There are many changed lines, but most are formatting for PEP8, so it
>> shouldn't take too long...
>>
>> Changes other than formatting changes include:
>> - condensing some nested (try/except - try/finally) into
>> try/except/finally
>> - changed reader in TreeAcc from xml.dom.ext.reader to xml.dom/minicom
>> - wrote a tree walker in TreeAcc to replace the one which went away
>> in 2.6
>> - got rid of Trace in install_utils
>> - removed py function call handling (which never worked and gave 2.6
>> pylint errors) from finalizer
>>
>> Thanks,
>> Jack
>>
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
