Jan Damborsky wrote:
> Hi Jean,
>
> please see my comments below.
>
> Thank you,
> Jan
>
>
>
> ti_defs.py
> ----------
>
> Since it is not to be invoked as standalone application
> (only imported as Python module), I think we could just
> remove shebang line.
I think you're right.
>
>
> libtransfer.c
> -------------
>
> According to [1], PyImport_Import() now defaults to absolute imports,
> so I think that following line should be changed:
>
> 33 #define TRANSFER_PY_SCRIPT "transfer_mod"
> ->
> 33 #define TRANSFER_PY_SCRIPT "osol_install.transfer_mod"
>
>
> Also I think that then we could remove following lines
> (no need to set PYTHONPATH):
>
> 37-45, 162-167, 288-292
>
>
> I have given this change a try using current 2.4 stuff (in order
> to check if setting PYTHONPATH is needed) and it worked just fine
> without this.
>
>
> nit:
>
> 75 if (NULL == (m = Py_InitModule("libtransfer",
> libtransferMethods))) {
> ->
> 75 if ((m = Py_InitModule("libtransfer", libtransferMethods))
> == NULL) {
>
>
> [1] http://docs.python.org/whatsnew/2.6.html#porting-to-python-2-6
>
>
If we get rid of the PYTHONPATH then yeah, changing TRANSFER_PY_SCRIPT
would be needed.
I'll change both.
I'll also change line 75 to be more readable as you suggest.
Jean
>
>
> jeanm wrote:
>> Webrev is here:
>> http://cr.opensolaris.org/~jeanm/slim_2.6/
>>
>>
>> Jean
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
