Hi all,
I've updated the usr/src/cmd/ai-webserver components to be 2.6
clean. Can Jean and/or Joe look at these changes and get responses back
so that we can wrap up by the 9th?
Further, in testing, I found a number of bugs which hadn't been
addressed but which fully broke these components and prevented me from
testing my changes -- I've as such, fixed these too. (I guess the
components don't see much use?) Unfortunately, there's not any regression
tests for publishing/listing/deleting manifests that I'm aware of. As such
I've done the following:
Tests -- for manifest publication
(all should work unless otherwise specified):
-------------------------------------------------------------------------------
Try the webserver stock out of an fresh create-service
Try to download the default.xml file via the BUI
(All tests below involve checking list-manifest and the webserver BUI to
ensure things are correct afterwords)
Try to publish a new default manifest
Try to publish a new default manifest (but with criteria) -- should fail
Try to publish a new non-default manifest (with one criteria)
Try to publish a the same non-default manifest (but with two criteria)
Try to publish a new non-default manifest (with any number of criteria)
Try to publish a non-default manifest (with a duplicate criteria set) --
should fail
Try to download non-default manifest using manual testing interface
(http://<server>:<port>/manifest.html)
Try to remove an instance of the first manifest
(delete-manifest -i <instance> <manifest name> /var/ai/<port>)
Try to remove all instances of the first manifest
(installadm remove -n <service> -m <manifest>)
PyLint:
-------------------------------------------------------------------------------
These files have seen some PEP8 clean-up, however, due to time
constraints not all PEP8 suggestions were done. The pylint scores using
the install.pylint rc file are as follows:
verifyXML.py
Your code has been rated at 5.84/10
AI_database.py
Your code has been rated at 3.39/10
publish-manifest.py
Your code has been rated at 3.12/10
delete-manifest.py
Your code has been rated at 1.17/10
webserver.py
Your code has been rated at 1.01/10
list-manifest.py
PyLint fails to run on this
Webrev:
http://cr.opensolaris.org/~clayb/python2.6/
Bugs addressed:
8015 list-manifests output is hard to read
11607 Should remove "prototype" out of AI commands
12162 Need to transition the AI webserver to use the SQLite3 module
instead of PySQLite2
12424 AI Websever unable to handle manifest with null IPv4 or MAC address
criteria if set in at least one manifest
Thank you,
Clay
