William Schumann wrote: > webrev: http://cr.opensolaris.org/~wmsch/bug-12459/ > > If no Solaris partition was either pre-existing, specified in AI > manifest, or specified from AI default action on selected disk, > om_perform_slim_install was not returning OM_FAILURE, leading AI to > misread the returned status and continue waiting. Fixed return code and > improved user instructions and log messages. > > Tested AI: > - creating missing Solaris scenario > - providing Solaris partition > Tested GUI: > - GUI does not reach this code, since the GUI requires a Solaris > partition to exist or to be requested before the user can proceed with > the installation. > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss Looks good William.
One minor issue and one question. - - - usr/src/lib/liborchestrator/perform_slim_install.c Minor issue: This comment seems invalid to me. 445 * Will be set in function above. usr/src/cmd/auto-install/auto_install.c Would it be possible to avoid one of these to very similar calls? 1256 auto_debug_print(AUTO_DBGLVL_ERR, NO_PART_MSG()); 1257 auto_log_print(NO_PART_MSG()); Joe
