On Mon, 16 Nov 2009, jeanm wrote: > Alok Aggarwal wrote: >> >> On Mon, 16 Nov 2009, jeanm wrote: >> >>> Could I get a code review (Alok and Jan preferred) for the following: >>> >>> 12612 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12612> >>> get_service_with_global_scope() looks in the wrong place for the boot >>> archive >>> 12642 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12642> platform >>> directory needs to only contain the necessary files >>> >>> >>> >>> >>> >>> webrev: >>> >>> http://cr.opensolaris.org/~jeanm/slim_12612_12642/ >> >> setup-sparc.sh: line 96: I think this comment needs to be >> updated to account for the existence of the boot_archive in >> /boot and /boot/platform/sun4v, one of which is for backward >> compatibility reasons. > Will do. >> >> setup-sparc.sh: lines 108-116: Don't we want to recompute >> 'root_file_location' if the check on 105 fails? > Or maybe throw an error? If that fails something is woefully wrong.
So, first recompute 'root_file_location' to account for backward compatibility cases. If that fails, then throw an error. Alok
