Jan Damborsky wrote: > Hi Niall, > > could I please ask you for reviewing the fix for following CRs ? > > 3448 GUI needs to be enhanced in order to support +1TB phase 1 project > http://defect.opensolaris.org/bz/show_bug.cgi?id=3448 > > * Webrev: > http://cr.opensolaris.org/~dambi/bug-3448/ > > Thank you very much, > Jan > > > The modules affected and tested: > * liborchestrator, gui-install > > test conditions: > * platform: > - vmWare (800 MiB RWM for guest OS) running > on W2110Z (2GiB RWM) > > * ISO: OpenSolaris based on build 98 > > tests carried out: > Since disks >1TB are not available for testing, > I set the disk size limit to 5GB and used 4GB and > 8GB disks in vmware for testing purposes. I verified > that for 8GB disk > * disk icon was tagged with warning tag > * appropriate warning message was displayed in icon message area > * spinners upper bound was set to 5GB > > Regression tests were done with 4GB disk > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
usr/src/lib/liborchestrator/target_discovery.c ---------------------------------------------- Looks good usr/src/lib/liborchestrator/perform_slim_install.c -------------------------------------------------- a nit: ------ I propose using a constant in place of 2047 to simplify the changes needed when in the future support for larger disks is added and perhaps might add a little to make the code more self documenting... ? my proposed changes in lib/liborchestrator/orchestrator_private.h #define MAX_USABLE_DISK 2047 from: 1508 return (2047 * ONE_GB_TO_MB); to: 1508 return (MAX_USABLE_DISK * ONE_GB_TO_MB); usr/src/lib/liborchestrator/orchestrator_api.h ----------------------------------------------- looks good usr/src/lib/liborchestrator/disk_info.c --------------------------------------- looks good usr/src/cmd/gui-install/src/orchestrator-wrappers.h --------------------------------------------------- looks good usr/src/cmd/gui-install/src/orchestrator-wrappers.c --------------------------------------------------- looks good usr/src/cmd/gui-install/src/installation-disk-screen.c ------------------------------------------------------ Issue 1 ------- I am not a gtk expert so please confirm the code on lines 723 -> 749 is correct. If the disk is not too big in place of gtk_label_set_markup gtk_label_set_text is used. Is this correct? Shouldn't the same thing be done if the disk is not too big after the "disk is too big" warning message is displayed? This is how the DISK_STATUS_CANT_PRESERVE case is handled under line: 783 case DISK_STATUS_CANT_PRESERVE: Maybe I am just confused... I just would like to ask that you double check this code to make sure it is correct. Again, please confirm the code on lines 723 -> 749 is correct. Issue 2: -------- Shouldn't this comment be updated? 1699 /* Label consists of: "<sizeinGB>[GB|MB] <disktype> */
