Hi Alok,
Alok Aggarwal wrote: > Hi Jan, > > On Thu, 6 Nov 2008, jan damborsky wrote: > >> Hi, >> >> since Dave already took a look at the changes, >> could I please ask one more pair of eyes to review >> easy fix for following AI stopper ? >> >> 4543 Setting keyboard layout failed in automated installation >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4543 >> >> The webrev is available at: >> http://cr.opensolaris.org/~dambi/bug-4543 > > Looks fine. Is there a bug filed on getting > the keyboard specification included in the > AI manifest yet? If not, could you please file > one and add a comment that this fix would need > to be undone at that time? Done - I have filed 4585 Automated Installer needs support for setting keyboard layout from AI manifest > > Since AI does not support locales other than > C/Posix right now, I'm assuming this change > does not need to be release noted or mentioned > anywhere is the docs, correct? This is my understanding as well - since there is currently no mechanism to make it configurable, we need to use hardcoded value at time of being. I agree with you that should be fine, as only "C" locale is supported in 2008.11. Thanks for the review ! Jan > > Alok
